Skip to content

Update requirements to HDMF 5 #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rly wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

Update requirements to HDMF 5 #681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@


### Improvements
* Updated HDMF dependency to version 5+. [#675](https://github.com/NeurodataWithoutBorders/nwbinspector/issues/675)

### Fixes

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ classifiers = [
requires-python = ">=3.10"
dependencies = [
"pynwb>=3.1", # NWB Inspector should always be used with most recent minor versions of PyNWB
"hdmf>=5",
"hdmf-zarr",
"fsspec",
"requests",
Expand Down
8 changes: 6 additions & 2 deletions tests/unit_tests/test_tables.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ def setUp(self):
self.table.add_row(test_column=1)

def test_check_dynamic_table_region_data_validity_lt_zero(self):
dynamic_table_region = DynamicTableRegion(name="dyn_tab", description="desc", data=[-1, 0], table=self.table)
dynamic_table_region = DynamicTableRegion(
name="dyn_tab", description="desc", data=[-1, 0], table=self.table, validate_data=False
)

assert check_dynamic_table_region_data_validity(dynamic_table_region) == InspectorMessage(
message="Some elements of dyn_tab are out of range because they are less than 0.",
Expand All @@ -43,7 +45,9 @@ def test_check_dynamic_table_region_data_validity_lt_zero(self):
)

def test_check_dynamic_table_region_data_validity_gt_len(self):
dynamic_table_region = DynamicTableRegion(name="dyn_tab", description="desc", data=[0, 20], table=self.table)
dynamic_table_region = DynamicTableRegion(
name="dyn_tab", description="desc", data=[0, 20], table=self.table, validate_data=False
)

assert check_dynamic_table_region_data_validity(dynamic_table_region) == InspectorMessage(
message=(
Expand Down
Loading