Skip to content

Fix external-file ImageSeries test and require pynwb>=4.0 #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rly merged 4 commits into from
Jun 30, 2026
Merged

Fix external-file ImageSeries test and require pynwb>=4.0 #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f7ddcc
Set num_samples in external-file ImageSeries test for PyNWB 4.0
rly Jun 30, 2026
5405ab3
Require pynwb>=4.0
rly Jun 30, 2026
3a963a1
Add changelog entries for PyNWB 4.0 fixes
rly Jun 30, 2026
7c57e8a
Merge branch 'dev' into fix/image-series-num-samples-pynwb-4
bendichter Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@
### New Checks

### Improvements
* Raised the minimum required PyNWB to `>=4.0` to track the latest PyNWB release. [#708](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/708)
* Bumped GitHub Actions workflow dependencies (`actions/checkout` v4 -> v6, `actions/setup-python` v5 -> v6, `codecov/codecov-action` v4 -> v5) to migrate off Node.js 20, which GitHub is removing from runners on 2026-09-16. [#702](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/702)

### Fixes
* Fixed unit tests that failed at construction time against recent PyNWB and HDMF. [#707](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/707) [#708](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/708)
* Skipped Ontobee in the documentation external link check, which frequently timed out and caused spurious CI failures. [#709](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/709)
* Fixed unit tests that failed at construction time against recent PyNWB and HDMF. [#707](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/707)
* Fixed `run_checks` raising `TypeError` when a `progress_bar_class` was passed without `progress_bar_options`; the keyword arguments are now coalesced to an empty dict before being forwarded to the progress-bar constructor. [#701](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/701)

# v0.7.2 (May 19, 2026)
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ classifiers = [
]
requires-python = ">=3.10"
dependencies = [
"pynwb>=3.1", # NWB Inspector should always be used with most recent minor versions of PyNWB
"pynwb>=4.0", # NWB Inspector should always be used with most recent minor versions of PyNWB
"fsspec",
"requests",
"aiohttp",
Expand Down
1 change: 1 addition & 0 deletions tests/unit_tests/test_image_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def test_check_image_series_external_file_valid_bytestring_pass(self):
rate=1.0,
external_file=[bytes("/".join([".", good_external_path.name]), "utf-8")],
format="external",
num_samples=1,
)
assert check_image_series_external_file_relative(image_series=image_series) is None

Expand Down
Loading