Conversation
Also remove old-style super() calls and call_docval_func
Codecov Report
@@ Coverage Diff @@
## dev #1484 +/- ##
==========================================
+ Coverage 78.24% 78.27% +0.03%
==========================================
Files 37 37
Lines 2799 2757 -42
Branches 473 486 +13
==========================================
- Hits 2190 2158 -32
+ Misses 524 518 -6
+ Partials 85 81 -4
Continue to review full report at Codecov.
|
|
This looks like a really big PR, but no functionality has changed. This PR does not introduce warnings for using positional arguments for most NWB neurodata type classes, but sets the foundation for it. That change will be in the next minor release. A minor bug was fixed in There is still a warning about the length of data not matching the length of timestamps when an ImageSeries is created where an external file is used and timestamps are provided. In this case, a placeholder 'data' is set with shape (0,0,0). Again, this is a case where ImageSeries, when not used to store data in the |
Use the just released HDMF 3.3.1. Note that HDMF 3.3 introduces warnings when positional arguments are used in subclasses of many base types. This PR replaces positional args with keyword args in source code and tests throughout. Fix #1189
Also remove old-style
super()calls and calls tocall_docval_funcChecklist
flake8from the source directory.