-
Notifications
You must be signed in to change notification settings - Fork 93
Implement data types from NWBEP001 #2156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rly
wants to merge
20
commits into
dev
Choose a base branch
from
nwbep001
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1bc3ee5
Point to nwbep001 branch in nwb-schema
rly 3d90adc
Implements TimestampVectorData, DurationVectorData, EventsTable
rly 9fdcf8c
Add deprecations
rly eb55755
Clarify TimestampVectorData docstring
rly 38a8feb
Require description arg for TimestampVectorData and DurationVectorData
rly 98a9888
Merge branch 'dev' into nwbep001
rly 1a0b5ea
Un-deprecate TimeSeries continuity="instantaneous"; soften Behavioral…
rly 6acaec8
Add EventsTable examples to behavior and file basics galleries
rly 04fc54b
Add changelog entry for EventsTable gallery examples
rly c7e6e11
Add changelog entries for NWBEP001 schema and deprecations
rly 3bf95a9
Link NWBEP001 changelog entries to PR #2156
rly 7e5db40
Remove erroneous PR #2156 link from HERD changelog entry
rly 731d926
Revert errant replace_all in CHANGELOG and re-link only NWBEP001 entr…
rly 2343bc1
Fix stale EventsTable test docstring and DurationVectorData resolutio…
rly f26dd2b
Replace tempfile.mktemp with TemporaryDirectory in EventsTable tests
rly b0a15bd
Use pathlib.Path for EventsTable test file path
rly e3924fe
Forward meanings_tables kwarg in DynamicTable subclass constructors
rly ee2c771
Use NWBH5IOFlexMixin for canonical EventsTable roundtrip test
rly 06fa11c
Test meanings_tables on EventsTable; document __init__ override; bump…
rly 75f052f
Clarify resolution docstrings on TimestampVectorData/DurationVectorData
rly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a separate issue, but this seems like a great place to also introduce a
Meaningstable to define what "grooming" and "rearing" means.