[codex] Preserve legacy device model names on read#2186
Draft
bendichter wants to merge 2 commits intodevfrom
Draft
[codex] Preserve legacy device model names on read#2186bendichter wants to merge 2 commits intodevfrom
bendichter wants to merge 2 commits intodevfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2186 +/- ##
=======================================
Coverage 95.10% 95.11%
=======================================
Files 29 29
Lines 2943 2948 +5
Branches 443 443
=======================================
+ Hits 2799 2804 +5
Misses 86 86
Partials 58 58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2185
Summary
Fixes the read-time remapping path for legacy files where
Device.modelis stored as a string containing characters such as/or:.Instead of sanitizing the legacy value, PyNWB now constructs the remapped
DeviceModelin HDMF construct mode, matching the normal file-read construction path. This preserves the original model name in memory while still avoiding the user-facing name validation that is meant to prevent invalid newly-created container names.Root cause
DeviceMapper.model_cargmanually created aDeviceModelwithDeviceModel(...). That bypassed HDMF's usual read-timein_construct_mode=Truepath, soAbstractContainer.__init__rejected legacy model strings containing/or:.Validation
PYTHONPATH=src .tox/test-py312-pinned/bin/python -m pytest tests/unit/test_device.py -qPYTHONPATH=src .tox/test-py312-pinned/bin/python -m pytest tests/back_compat/test_read.py::TestReadOldVersions::test_read_device_model_str_attribute -qpython -m tox -e test-py312-pinned -- tests/unit/test_device.py(683 tests - OK)