Merge branch 'release/0.8.13'

ljonesfl · ljonesfl · commit 33f4181af550 · 2026-01-13T12:17:05.000-06:00
diff --git a/.version.json b/.version.json
@@ -2,6 +2,6 @@
   "strategy": "semver",
   "major": 0,
   "minor": 8,
-  "patch": 12,
+  "patch": 13,
   "build": 0
 }
diff --git a/src/Cli/Application.php b/src/Cli/Application.php
@@ -7,6 +7,7 @@
 use Neuron\Cli\Console\Input;
 use Neuron\Cli\Console\Output;
 use Neuron\Cli\Loader\ComponentLoader;
+use Neuron\Core\Registry\RegistryKeys;
 use Neuron\Data\Settings\Source\ISettingSource;
 use Neuron\Log\Log;
 
@@ -131,8 +132,8 @@ protected function onStart(): bool
 	protected function executeCommand(): void
 	{
 		// Store the application instance in the registry for commands to access
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $this );
-		
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $this );
+
 		// Check if command exists
 		if( !$this->commandRegistry->has( $this->commandName ) )
 		{
@@ -174,7 +175,7 @@ protected function executeCommand(): void
 			$exitCode = $command->execute();
 			
 			// Store exit code in registry for bin/neuron to retrieve
-			\Neuron\Patterns\Registry::getInstance()->set( 'cli.exit_code', $exitCode );
+			\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_EXIT_CODE_LEGACY, $exitCode );
 		}
 		catch( \Exception $e )
 		{
@@ -186,7 +187,7 @@ protected function executeCommand(): void
 			}
 			
 			// Store error exit code
-			\Neuron\Patterns\Registry::getInstance()->set( 'cli.exit_code', 1 );
+			\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_EXIT_CODE_LEGACY, 1 );
 		}
 	}
 
@@ -309,8 +310,8 @@ private function showHelp(): void
 	private function showCommandHelp( string $commandName ): void
 	{
 		// Store the application instance in the registry for commands to access
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $this );
-		
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $this );
+
 		if( !$this->commandRegistry->has( $commandName ) )
 		{
 			$this->output->error( "Command '{$commandName}' not found" );
@@ -370,6 +371,6 @@ public function getCurrentCommand(): ?Commands\Command
 	 */
 	public function getExitCode(): int
 	{
-		return \Neuron\Patterns\Registry::getInstance()->get( 'cli.exit_code' ) ?? 0;
+		return \Neuron\Patterns\Registry::getInstance()->get( RegistryKeys::CLI_EXIT_CODE_LEGACY ) ?? 0;
 	}
 }
diff --git a/src/Cli/Commands/Core/ComponentListCommand.php b/src/Cli/Commands/Core/ComponentListCommand.php
@@ -4,6 +4,7 @@
 
 use Neuron\Cli\Commands\Command;
 use Neuron\Cli\Commands\Registry;
+use Neuron\Core\Registry\RegistryKeys;
 
 /**
  * Lists all available commands organized by component
@@ -41,7 +42,7 @@ public function configure(): void
 	public function execute(): int
 	{
 		// Get the application from registry
-		$app = \Neuron\Patterns\Registry::getInstance()->get( 'cli.application' );
+		$app = \Neuron\Patterns\Registry::getInstance()->get( RegistryKeys::CLI_APPLICATION_LEGACY );
 		
 		if( !$app )
 		{
diff --git a/src/Cli/Commands/Core/HelpCommand.php b/src/Cli/Commands/Core/HelpCommand.php
@@ -3,6 +3,7 @@
 namespace Neuron\Cli\Commands\Core;
 
 use Neuron\Cli\Commands\Command;
+use Neuron\Core\Registry\RegistryKeys;
 use Neuron\Patterns\Registry;
 
 /**
@@ -49,7 +50,7 @@ public function execute(): int
 		}
 		
 		// Get the application from registry
-		$app = Registry::getInstance()->get( 'cli.application' );
+		$app = Registry::getInstance()->get( RegistryKeys::CLI_APPLICATION_LEGACY );
 		
 		if( !$app )
 		{
diff --git a/tests/Cli/Commands/Core/ComponentListCommandTest.php b/tests/Cli/Commands/Core/ComponentListCommandTest.php
@@ -6,6 +6,7 @@
 use Neuron\Cli\Commands\Registry;
 use Neuron\Cli\Console\Input;
 use Neuron\Cli\Console\Output;
+use Neuron\Core\Registry\RegistryKeys;
 use PHPUnit\Framework\TestCase;
 
 class ComponentListCommandTest extends TestCase
@@ -73,7 +74,7 @@ public function testExecuteFormattedList(): void
 		$this->registry->register( 'test:command', 'Tests\Cli\Commands\Core\MockTestCommand' );
 		$this->registry->register( 'help', 'Neuron\Cli\Commands\Core\HelpCommand' );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $app );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $app );
 
 		$input = new Input( [] );
 		$input->parse( $this->command );
@@ -95,7 +96,7 @@ public function testExecuteRawList(): void
 		$this->registry->register( 'test:command', 'Tests\Cli\Commands\Core\MockTestCommand' );
 		$this->registry->register( 'help', 'Neuron\Cli\Commands\Core\HelpCommand' );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $app );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $app );
 
 		$input = new Input( ['--raw'] );
 		$input->parse( $this->command );
@@ -120,7 +121,7 @@ public function testExecuteWithNamespaceFilter(): void
 		$this->registry->register( 'help', 'Neuron\Cli\Commands\Core\HelpCommand' );
 		$this->registry->register( 'other:command', 'Tests\Cli\Commands\Core\MockTestCommand' );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $app );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $app );
 
 		$input = new Input( ['--namespace=test'] );
 		$input->parse( $this->command );
@@ -142,7 +143,7 @@ public function testExecuteWithEmptyRegistry(): void
 		$app = $this->createMockApplication();
 		// Don't register any commands
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $app );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $app );
 
 		$input = new Input( [] );
 		$input->parse( $this->command );
@@ -161,7 +162,7 @@ public function testExecuteWithNamespaceFilterNoMatches(): void
 		$app = $this->createMockApplication();
 		$this->registry->register( 'test:command', 'Tests\Cli\Commands\Core\MockTestCommand' );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $app );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $app );
 
 		$input = new Input( ['--namespace=nonexistent'] );
 		$input->parse( $this->command );
@@ -183,7 +184,7 @@ public function testRawListWithNamespaceFilter(): void
 		$this->registry->register( 'test:command2', 'Tests\Cli\Commands\Core\MockTestCommand' );
 		$this->registry->register( 'other:command', 'Tests\Cli\Commands\Core\MockTestCommand' );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $app );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $app );
 
 		$input = new Input( ['--raw', '--namespace=test'] );
 		$input->parse( $this->command );
@@ -206,7 +207,7 @@ public function testFormattedListGroupsAndSortsNamespaces(): void
 		$this->registry->register( 'zebra:test', 'Tests\Cli\Commands\Core\MockTestCommand' );
 		$this->registry->register( 'alpha:test', 'Tests\Cli\Commands\Core\MockTestCommand' );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $app );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $app );
 
 		$input = new Input( [] );
 		$input->parse( $this->command );
diff --git a/tests/Cli/Commands/Core/HelpCommandTest.php b/tests/Cli/Commands/Core/HelpCommandTest.php
@@ -6,6 +6,7 @@
 use Neuron\Cli\Commands\Registry;
 use Neuron\Cli\Console\Input;
 use Neuron\Cli\Console\Output;
+use Neuron\Core\Registry\RegistryKeys;
 use PHPUnit\Framework\TestCase;
 
 class HelpCommandTest extends TestCase
@@ -91,7 +92,7 @@ public function testGeneralHelpContainsExamples(): void
 	public function testExecuteWithoutApplicationInRegistry(): void
 	{
 		// Clear registry
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', null );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, null );
 
 		$input = new Input( ['test:command'] );
 		$input->parse( $this->command );
@@ -111,7 +112,7 @@ public function testExecuteWithNonExistentCommand(): void
 		$mockApp = $this->createMock( \Neuron\Cli\Application::class );
 		$mockApp->method( 'has' )->willReturn( false );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $mockApp );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $mockApp );
 
 		$input = new Input( ['nonexistent:command'] );
 		$input->parse( $this->command );
@@ -140,7 +141,7 @@ public function testExecuteWithNonExistentCommandClass(): void
 		$mockApp->method( 'has' )->willReturn( true );
 		$mockApp->method( 'getRegistry' )->willReturn( $mockRegistry );
 
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $mockApp );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $mockApp );
 
 		$input = new Input( ['test:command'] );
 		$input->parse( $this->command );
@@ -154,12 +155,12 @@ public function testExecuteWithNonExistentCommandClass(): void
 		$this->assertStringContainsString( 'Command class not found', $output );
 
 		// Cleanup
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', null );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, null );
 	}
 
 	protected function tearDown(): void
 	{
 		// Cleanup registry after each test
-		\Neuron\Patterns\Registry::getInstance()->set( 'cli.application', null );
+		\Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, null );
 	}
 }
diff --git a/versionlog.md b/versionlog.md
@@ -1,3 +1,5 @@
+## 0.8.13 2026-01-13
+
 ## 0.8.12 2026-01-12
 
 ## 0.8.11 2026-01-06

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,6 @@`
`2`	`2`	`"strategy": "semver",`
`3`	`3`	`"major": 0,`
`4`	`4`	`"minor": 8,`
`5`		`- "patch": 12,`
	`5`	`+ "patch": 13,`
`6`	`6`	`"build": 0`
`7`	`7`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`	`use Neuron\Cli\Console\Input;`
`8`	`8`	`use Neuron\Cli\Console\Output;`
`9`	`9`	`use Neuron\Cli\Loader\ComponentLoader;`
	`10`	`+use Neuron\Core\Registry\RegistryKeys;`
`10`	`11`	`use Neuron\Data\Settings\Source\ISettingSource;`
`11`	`12`	`use Neuron\Log\Log;`
`12`	`13`
`@@ -131,8 +132,8 @@ protected function onStart(): bool`
`131`	`132`	`protected function executeCommand(): void`
`132`	`133`	`{`
`133`	`134`	`// Store the application instance in the registry for commands to access`
`134`		`- \Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $this );`
`135`		`-`
	`135`	`+ \Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $this );`
	`136`	`+`
`136`	`137`	`// Check if command exists`
`137`	`138`	`if( !$this->commandRegistry->has( $this->commandName ) )`
`138`	`139`	`{`
`@@ -174,7 +175,7 @@ protected function executeCommand(): void`
`174`	`175`	`$exitCode = $command->execute();`
`175`	`176`
`176`	`177`	`// Store exit code in registry for bin/neuron to retrieve`
`177`		`- \Neuron\Patterns\Registry::getInstance()->set( 'cli.exit_code', $exitCode );`
	`178`	`+ \Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_EXIT_CODE_LEGACY, $exitCode );`
`178`	`179`	`}`
`179`	`180`	`catch( \Exception $e )`
`180`	`181`	`{`
`@@ -186,7 +187,7 @@ protected function executeCommand(): void`
`186`	`187`	`}`
`187`	`188`
`188`	`189`	`// Store error exit code`
`189`		`- \Neuron\Patterns\Registry::getInstance()->set( 'cli.exit_code', 1 );`
	`190`	`+ \Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_EXIT_CODE_LEGACY, 1 );`
`190`	`191`	`}`
`191`	`192`	`}`
`192`	`193`
`@@ -309,8 +310,8 @@ private function showHelp(): void`
`309`	`310`	`private function showCommandHelp( string $commandName ): void`
`310`	`311`	`{`
`311`	`312`	`// Store the application instance in the registry for commands to access`
`312`		`- \Neuron\Patterns\Registry::getInstance()->set( 'cli.application', $this );`
`313`		`-`
	`313`	`+ \Neuron\Patterns\Registry::getInstance()->set( RegistryKeys::CLI_APPLICATION_LEGACY, $this );`
	`314`	`+`
`314`	`315`	`if( !$this->commandRegistry->has( $commandName ) )`
`315`	`316`	`{`
`316`	`317`	`$this->output->error( "Command '{$commandName}' not found" );`
`@@ -370,6 +371,6 @@ public function getCurrentCommand(): ?Commands\Command`
`370`	`371`	`*/`
`371`	`372`	`public function getExitCode(): int`
`372`	`373`	`{`
`373`		`- return \Neuron\Patterns\Registry::getInstance()->get( 'cli.exit_code' ) ?? 0;`
	`374`	`+ return \Neuron\Patterns\Registry::getInstance()->get( RegistryKeys::CLI_EXIT_CODE_LEGACY ) ?? 0;`
`374`	`375`	`}`
`375`	`376`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`use Neuron\Cli\Commands\Command;`
`6`	`6`	`use Neuron\Cli\Commands\Registry;`
	`7`	`+use Neuron\Core\Registry\RegistryKeys;`
`7`	`8`
`8`	`9`	`/**`
`9`	`10`	`* Lists all available commands organized by component`
`@@ -41,7 +42,7 @@ public function configure(): void`
`41`	`42`	`public function execute(): int`
`42`	`43`	`{`
`43`	`44`	`// Get the application from registry`
`44`		`- $app = \Neuron\Patterns\Registry::getInstance()->get( 'cli.application' );`
	`45`	`+ $app = \Neuron\Patterns\Registry::getInstance()->get( RegistryKeys::CLI_APPLICATION_LEGACY );`
`45`	`46`
`46`	`47`	`if( !$app )`
`47`	`48`	`{`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`namespace Neuron\Cli\Commands\Core;`
`4`	`4`
`5`	`5`	`use Neuron\Cli\Commands\Command;`
	`6`	`+use Neuron\Core\Registry\RegistryKeys;`
`6`	`7`	`use Neuron\Patterns\Registry;`
`7`	`8`
`8`	`9`	`/**`
`@@ -49,7 +50,7 @@ public function execute(): int`
`49`	`50`	`}`
`50`	`51`
`51`	`52`	`// Get the application from registry`
`52`		`- $app = Registry::getInstance()->get( 'cli.application' );`
	`53`	`+ $app = Registry::getInstance()->get( RegistryKeys::CLI_APPLICATION_LEGACY );`
`53`	`54`
`54`	`55`	`if( !$app )`
`55`	`56`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+## 0.8.13 2026-01-13`
	`2`	`+`
`1`	`3`	`## 0.8.12 2026-01-12`
`2`	`4`
`3`	`5`	`## 0.8.11 2026-01-06`