fixes

Author: ljonesfl

src/Routing/RouteMap.php

@@ -211,15 +211,28 @@ public function getName()
 	/**
 	 * Set the name for this route and register it with the router for duplicate detection.
 	 *
-	 * @param mixed $name
+	 * @param string $name
 	 * @return RouteMap
 	 * @throws Exceptions\DuplicateRouteException If name is already in use
 	 */
-	public function setName( $name ) : RouteMap
+	public function setName( string $name ) : RouteMap
 	{
-		// If router context is set, register the name for duplicate detection
+		// If the name is already set to this value, no need to re-register
+		if( $this->Name === $name )
+		{
+			return $this;
+		}
+
+		// If router context is set, unregister old name and register the new one
 		if( $this->_router && $this->_method )
 		{
+			// Unregister the old name if one exists
+			if( $this->Name !== '' )
+			{
+				$this->_router->unregisterRouteName( $this->Name );
+			}
+
+			// Register the new name (will check for duplicates)
 			$this->_router->registerRouteName( $name, $this->_method, $this->Path, $this );
 		}
 

src/Routing/Router.php

@@ -235,16 +235,18 @@ protected function addRoute( array &$routes, string $method, string $routeName,
 		// Set router context so the route can register names for duplicate detection
 		$route->setRouterContext( $this, $method );
 
-		// Set the route name if provided (this will trigger duplicate name check)
-		if( $name )
+		// Check for duplicate path+method combinations BEFORE setting the name
+		// This ensures that if the path check throws, no name gets registered
+		if( $this->_strictMode )
 		{
-			$route->setName( $name );
+			$this->checkDuplicateRoute( $route, $method );
 		}
 
-		// Check for duplicate path+method combinations if strict mode is enabled
-		if( $this->_strictMode )
+		// Set the route name if provided (this will trigger duplicate name check)
+		// This is done AFTER path checking to avoid leaving stale names on error
+		if( $name )
 		{
-			$this->checkDuplicateRoute( $route, $method );
+			$route->setName( $name );
 		}
 
 		$routes[] = $route;
@@ -297,6 +299,20 @@ public function registerRouteName( string $name, string $method, string $path, R
 		$this->_registeredNames[ $name ] = "{$method}:{$path}";
 	}
 
+	/**
+	 * Unregister a route name (called by RouteMap::setName when renaming).
+	 *
+	 * This method is called when a route's name is being changed, allowing
+	 * the old name to be removed from the registry before registering the new name.
+	 *
+	 * @param string $name The route name to unregister
+	 * @return void
+	 */
+	public function unregisterRouteName( string $name ): void
+	{
+		unset( $this->_registeredNames[ $name ] );
+	}
+
 	/**
 	 * Check if a route is a duplicate and throw exception if found.
 	 *