Issue with pairwise comparison in compare_documents function#2
Open
bytemouse wants to merge 1 commit into
Open
Issue with pairwise comparison in compare_documents function#2bytemouse wants to merge 1 commit into
bytemouse wants to merge 1 commit into
Conversation
comparisons are now pairwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compare_documents function in the current implementation does not perform pairwise comparison correctly when comparing documents. For n elements, there should be (n(n-1))/2 comparisons. Your code does for n=100 385 comparisons when it should do 4950. I am not quite sure why, but I think pairwise comparison is the intended function.