fix: address code review issues (arguments.callee, xpEarned, skills split)

Agent-Logs-Url: https://github.com/NextCommunity/NextCommunity.github.io/sessions/e7dc0226-fa25-488a-a713-47a2399e85cd

Co-authored-by: jbampton <418747+jbampton@users.noreply.github.com>

Author: Copilot

src/assets/js/games/code-breaker.js

@@ -225,15 +225,16 @@ const CodeBreaker = (function () {
     }).setOrigin(0.5);
 
     // Keep label synced with the physics body each frame
-    scene.events.on("update", function () {
+    function syncLabel() {
       if (tile.active) {
         label.x = tile.x;
         label.y = tile.y;
       } else {
         label.destroy();
-        scene.events.off("update", arguments.callee);
+        scene.events.off("update", syncLabel);
       }
-    });
+    }
+    scene.events.on("update", syncLabel);
 
     scene.cb_tiles.add(tile);
     scene.cb_spawnDelay = Math.max(600, scene.cb_spawnDelay - 20);

src/assets/js/games/dev-duel.js

@@ -247,14 +247,13 @@ const DevDuel = (function () {
   function _showResult(scene, challenger, opponent, cPower, oPower, W, H, theme) {
     const challengerWins = cPower >= oPower;
     const winner = challengerWins ? challenger : opponent;
-    const xpEarned = XP_DEV_DUEL_WIN;
 
     // Dim overlay
     const dimGfx = scene.add.graphics();
     dimGfx.fillStyle(0x000000, 0.6);
     dimGfx.fillRect(0, 0, W, H);
 
-    // Award XP and track stats
+    // Award XP for playing (all players earn this) and track stats
     GameManager.awardXP(XP_DEV_DUEL_PLAY);
     const duels = GameManager.incrementStat("dev_duel_plays");
     if (duels >= 5) GameManager.grantAchievement("duelist");
@@ -290,7 +289,7 @@ const DevDuel = (function () {
       .setOrigin(0.5);
 
     scene.add
-      .text(W / 2, H / 2 + 35, "+" + xpEarned + " XP for playing!", {
+      .text(W / 2, H / 2 + 35, "+" + XP_DEV_DUEL_PLAY + " XP for playing!", {
         fontSize: "18px",
         fill: "#10b981",
         fontStyle: "bold",
@@ -346,10 +345,8 @@ function getCardData(cardEl) {
     name: (cardEl.dataset.name || "").trim(),
     role: (cardEl.dataset.role || "").trim(),
     skills: (cardEl.dataset.skills || "")
-      .split(",")
-      .map(function (s) {
-        return s.trim();
-      })
+      .trim()
+      .split(/\s+/)
       .filter(Boolean),
   };
 }