Skip to content

Clean up bio and profiles#453

Merged
jbampton merged 1 commit intoNextCommunity:mainfrom
jbampton:fix-bio-locations
May 2, 2026
Merged

Clean up bio and profiles#453
jbampton merged 1 commit intoNextCommunity:mainfrom
jbampton:fix-bio-locations

Conversation

@jbampton
Copy link
Copy Markdown
Member

@jbampton jbampton commented May 2, 2026

No description provided.

@jbampton jbampton self-assigned this May 2, 2026
@jbampton jbampton added the good first issue Good for newcomers label May 2, 2026
@jbampton jbampton added this to Next May 2, 2026
@github-project-automation github-project-automation Bot moved this to In progress in Next May 2, 2026
@jbampton jbampton moved this from In progress to Review in progress in Next May 2, 2026
@jbampton jbampton merged commit 065e95a into NextCommunity:main May 2, 2026
9 of 10 checks passed
@jbampton jbampton deleted the fix-bio-locations branch May 2, 2026 10:41
@github-project-automation github-project-automation Bot moved this from Review in progress to Done in Next May 2, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the bio template to conditionally render the location and professional bio sections, ensuring they are hidden when data is missing. It also removes the website and email fields for the user jbampton. Feedback suggests simplifying the location display logic using the join filter and making the bio presence check more robust by using the trim filter to handle whitespace-only content.

Comment thread src/_includes/bio.njk
<div class="flex items-center gap-3">
<span class="text-lg">📍</span>
<span class="text-[var(--text-muted)]">{{ location }}{% if country %}, {{ country }}{% endif %}</span>
<span class="text-[var(--text-muted)]">{{ location }}{% if location and country %}, {% endif %}{{ country }}</span>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic for displaying the location and country can be simplified and made more robust by using the join filter. This ensures that the comma and space are only added when both values are present, and it handles potential whitespace issues more cleanly if combined with trim.

              <span class="text-[var(--text-muted)]">{{ [location, country] | select | join(', ') }}</span>

Comment thread src/_includes/bio.njk
</div>

<div class="lg:col-span-2 space-y-8">
{% if bio %}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To prevent rendering an empty card if the bio field contains only whitespace (e.g., from a YAML block scalar with only newlines), it is safer to check if the trimmed content is truthy.

        {% if bio | trim %}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant