Lynx sensor module - #16
Merged
Merged
Conversation
zachwaffle4
requested changes
Jul 27, 2026
| class NextFeedbackCRServo @JvmOverloads constructor( | ||
| initializer: () -> CRServoImplEx, | ||
| feedbackName: String, | ||
| feedbackInitializer: () -> AnalogInput, |
Collaborator
There was a problem hiding this comment.
These should still use AnalogFeedback.
| import dev.nextftc.units.measuretypes.Voltage | ||
| import dev.nextftc.units.volts | ||
|
|
||
| class NextAnalogInput @JvmOverloads constructor( |
Collaborator
There was a problem hiding this comment.
This should inherit from AnalogFeedback so it can be used more easily by the feedback (cr) servo classes.
| } | ||
| } | ||
|
|
||
| fun get(): T { |
There was a problem hiding this comment.
iirc, Rohit made the extra get function in order to keep the i2c buses all in one array, and avoid having to make 4 variables(one per bus)
Author
There was a problem hiding this comment.
its okay i js fixed, both should work i think mine just felt a little more intuitive for me
zachwaffle4
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
digital and i2c compatability