fix: inline definePlugin to remove runtime dependency on repterm-api#27
Closed
cnbailian wants to merge 1 commit into
Closed
fix: inline definePlugin to remove runtime dependency on repterm-api#27cnbailian wants to merge 1 commit into
cnbailian wants to merge 1 commit into
Conversation
When repterm is installed via symlink/link outside its monorepo, bun resolves imports from the symlink target path rather than the node_modules location. This causes 'Cannot find package repterm-api' errors because repterm-api isn't in the symlink target's resolution path. Fix by inlining the trivial definePlugin function and changing all repterm-api imports to type-only (erased at compile time). The repterm-api package remains in dependencies for TypeScript type resolution but is no longer needed at runtime. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
definePluginfunction (trivial:return { name, setup }) directly into repterm, eliminating the runtimeimportfromrepterm-apirepterm-apiimports toimport type(erased at compile time, no runtime module resolution)repterm-apistays independenciesfor TypeScript type resolution but is no longer needed at runtimeProblem
When repterm is installed via symlink/link outside its monorepo, bun resolves
import ... from 'repterm-api'from the symlink target path rather than thenode_moduleslocation. This causes:Test plan
bun run build:reptermsucceedsdist/plugin/index.jshas no runtimeimportfromrepterm-api🤖 Generated with Claude Code