feat(proxy-hosts): group label for organising hosts#5452
Conversation
Add optional host_group_label on proxy_host (migration + OpenAPI). UI: edit label in proxy host modal, group rows on list page with filter dropdown. English locale strings included.
Vacuum oas3-valid-schema-example requires examples to include all required proxy-host-object properties.
|
Docker Image for build 2 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
|
Thanks for this PR — grouping proxy hosts is a frequently requested quality-of-life feature and the overall approach is solid. A few things to address before merging: Bug — column sorting broken within groupsIn The fix is to iterate
Minor issues
Everything else looks good
|
|
This conflicts with #5358 - it would be nice if you both reach a consensus on who's got the best approach. If not I will eventually have to make that call. |
- Table: drive group rendering off the table row model (instead of raw data + ID lookup) so column sorting can order rows within each group - ProxyHostModal: i18n the group-label placeholder and add a length validation rule with inline error feedback - TableWrapper: replace the "__all__" group-filter sentinel with a null state and collision-free index-based option values - useProxyHost: fix indentation of the hostGroupLabel default value
Resolves a conflict in ProxyHosts/Table.tsx between this branch's group labelling and develop's new column-sorting feature (PR NginxProxyManager#5520). The group label is now a hidden, sort-only column pinned as the primary sort key, so each group's rows stay contiguous in the row model while a column the user clicks sorts rows within each group.
WhyProxy hosts pile up once you manage more than a handful, with no built-in way
The label is optional and defaults to an empty string, so existing hosts and API ChangesBackend
Frontend
This branch has been merged up to current Type of Change
|
Summary
Adds an optional group label on each proxy host so users can organise the list (e.g. by organisation, project, or any free-text label).
Changes
20260402000000_host_group_label.jsaddshost_group_label(string, default empty) toproxy_host.en.json); other locales fall back or can be added in follow-up.Upgrade
Migrations run automatically on backend startup (existing NPM upgrade flow).
Notes
Non-English locale files were not updated in this PR.