tests: added 45 tests, surfacing 4 bugs

- test: bugs/defects are skipped, unskip when fix lands
- change: add `node:` prefixes to builtins

Author: msimerson

.github/workflows/lint.js.yml

@@ -1,10 +1,9 @@
+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+
 name: Linting
 
-on:
-  push:
-    branches: [master, main]
-  pull_request:
-    types: [opened, synchronize, reopened]
+on: [push, pull_request]
 
 permissions:
   contents: read
@@ -13,9 +12,9 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v6
-      - uses: actions/setup-node@v6
-        with:
-          node-version: 24
-      - run: npm ci
-      - run: npm run lint
+    - uses: actions/checkout@v6
+    - uses: actions/setup-node@v6
+      with:
+        node-version: 24
+    - run: npm ci
+    - run: npm run lint

.github/workflows/node.js.yml

@@ -1,41 +1,32 @@
+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
+# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+
 name: Node.js CI
 
 on:
   push:
-    branches: [master, main]
+    branches: [ master ]
   pull_request:
+    branches: [ master ]
     types: [opened, synchronize, reopened]
 
 permissions:
   contents: read
 
 jobs:
   build:
-    needs: [get-lts]
+
     runs-on: ubuntu-latest
+
     strategy:
       matrix:
-        node-version: ${{ fromJson(needs.get-lts.outputs.lts) }}
+        node-version: [22, 24]
 
     steps:
-      - uses: actions/checkout@v6
-      - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v6
-        with:
-          node-version: ${{ matrix.node-version }}
-      - run: npm ci
-      - run: npm test
-
-  get-lts:
-    runs-on: ubuntu-latest
-    permissions:
-      contents: read
-    steps:
-      - id: get
-        uses: msimerson/node-lts-versions@v1
-    outputs:
-      active: ${{ steps.get.outputs.active }}
-      maintenance: ${{ steps.get.outputs.maintenance }}
-      lts: ${{ steps.get.outputs.lts }}
-      current: ${{ steps.get.outputs.current }}
-      min: ${{ steps.get.outputs.min }}
+    - uses: actions/checkout@v6
+    - name: Use Node.js ${{ matrix.node-version }}
+      uses: actions/setup-node@v6
+      with:
+        node-version: ${{ matrix.node-version }}
+    - run: npm ci
+    - run: npm test

.github/workflows/release.yml

@@ -1,12 +1,31 @@
+# Changelog
 
-### 2026-05-26
+The format is based on [Keep a Changelog](https://keepachangelog.com/).
 
-- client/udp.js refactors
-  1. Mismatched ids are dropped and the listener keeps waiting — stray packets no longer crash the process.
-  2. Sender filtering. Reject any packet whose rinfo.port isn't the configured resolver port; additionally enforce rinfo.address when dns is an IP literal (using net.isIP).
-  3. Defensive Packet.parse. Wrapped in try/catch so a malformed stray packet doesn't reject the promise — it's dropped with a debug log.
-  4. Timeout. New timeout option (default 10s, set 0 to disable). On expiry the promise rejects with code: 'ETIMEDOUT'. Timer is .unref()-ed so it never holds the event loop open.
-  5. Full 16-bit transaction IDs. query.header.id = crypto.randomInt(0x10000), 6.5× the keyspace and uses a CSPRNG.
-  6. Proper cleanup. Single cleanup() clears the timer, removes both listeners, and closes the socket; settled guard prevents double-resolve/reject from racing message + timeout.
-  7. Error event handled. Socket errors now reject the promise instead of going unhandled.
+### Unreleased
 
+- test: split tests into 3 files, add 45 new tests
+- feat(client/doh): HTTP/2 transport #89
+- feat(client/tcp): DNS-over-TLS support #88
+- feat(packet): IPv6 subnet support in `EDNS.ECS.decode`
+- feat(client/udp): configurable `timeout` (default 10s, `0` disables); rejects with `ETIMEDOUT`
+- fix(client/udp): drop mismatched-id packets instead of crashing
+- fix(client/udp): reject packets from non-resolver senders (port + IP literal via `net.isIP`)
+- fix(client/udp): defensive `Packet.parse` — malformed strays are dropped, not rejected
+- fix(client/udp): full 16-bit transaction ids via `crypto.randomInt`
+- fix(client/udp): single cleanup with settled-guard; socket `error` is handled
+- fix(client/tcp): empty response when server reply is async
+- fix(client/doh): enforce RFC 8484 `dns` query parameter, drop invalid pathname auto-completion #95
+- fix(server/udp): more resilient `udp4` default
+- fix(packet): guard against ERR_BUFFER_OUT_OF_BOUNDS on malformed requests
+- change(api): `resolve()` and UDP client take an options object (was `clientIp` positional) #84
+- dep(eslint): upgrade to v10
+- ci: modernize GitHub Actions workflows; add release.yml
+
+### 2.1.0 - 2024-06-26
+
+- feat(packet): DNSKEY record support
+- feat(packet): RRSIG record support (decode only)
+- feat(packet): `flatMap` support
+- fix(packet): ensure compressed IPv6 is valid #70
+- doc(README): correct `server.listen` options

CHANGELOG.md

@@ -1,6 +1,6 @@
-const http = require('http');
-const https = require('https');
-const http2 = require('http2');
+const http = require('node:http');
+const https = require('node:https');
+const http2 = require('node:http2');
 const Packet = require('../packet');
 
 const protocols = {

client/doh.js

@@ -1,4 +1,4 @@
-const https = require('https');
+const https = require('node:https');
 
 const get = url => new Promise(resolve =>
   https.get(url, resolve));

client/google.js

@@ -1,5 +1,5 @@
-const tls = require('tls');
-const tcp = require('net');
+const tls = require('node:tls');
+const tcp = require('node:net');
 const Packet = require('../packet');
 
 const makeQuery = ({ name, type = 'A', cls = Packet.CLASS.IN, clientIp, recursive = true }) => {

client/tcp.js

@@ -1,8 +1,8 @@
-const udp = require('dgram');
-const net = require('net');
-const crypto = require('crypto');
+const udp = require('node:dgram');
+const net = require('node:net');
+const crypto = require('node:crypto');
 const Packet = require('../packet');
-const { debuglog } = require('util');
+const { debuglog } = require('node:util');
 
 const debug = debuglog('dns2');
 

client/udp.js

@@ -7,7 +7,7 @@ const {
   createDOHServer,
   createServer,
 } = require('./server');
-const EventEmitter = require('events');
+const EventEmitter = require('node:events');
 
 /**
  * [DNS description]

index.js

@@ -4,7 +4,9 @@
   "description": "A DNS Server and Client Implementation in Pure JavaScript with no dependencies.",
   "main": "index.js",
   "scripts": {
-    "test": "node test",
+    "test": "node --test",
+    "test:coverage": "node --test --experimental-test-coverage",
+    "test:coverage:lcov": "mkdir -p coverage && node --test --experimental-test-coverage --test-reporter=lcov --test-reporter-destination=coverage/lcov.info",
     "lint": "npx eslint .",
     "lint:fix": "npx eslint . --fix",
     "example-server-udp": "node example/server/udp.js",