Skip to content

Commit 6feac53

Browse files
Remove Gui#remove in favor of Gui#setSlotElement with null
1 parent 31619c5 commit 6feac53

File tree

5 files changed

+4
-52
lines changed

5 files changed

+4
-52
lines changed

invui/src/main/java/xyz/xenondevs/invui/gui/AbstractGui.java

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -583,11 +583,6 @@ public void setSlotElement(int index, @Nullable SlotElement slotElement) {
583583
}
584584
}
585585

586-
@Override
587-
public void remove(int index) {
588-
setSlotElement(index, null);
589-
}
590-
591586
@Override
592587
public @Nullable SlotElement getSlotElement(int index) {
593588
return slotElements[index];
@@ -606,11 +601,7 @@ public SlotElement[] getSlotElements() {
606601

607602
@Override
608603
public void setItem(int index, @Nullable Item item) {
609-
if (item == null) {
610-
remove(index);
611-
return;
612-
}
613-
setSlotElement(index, new SlotElement.Item(item));
604+
setSlotElement(index, item != null ? new SlotElement.Item(item) : null);
614605
}
615606

616607
@Override
@@ -861,16 +852,6 @@ public void setItem(int x, int y, @Nullable Item item) {
861852
return getItem(convToIndex(x, y));
862853
}
863854

864-
@Override
865-
public void remove(Slot slot) {
866-
remove(slot.x(), slot.y());
867-
}
868-
869-
@Override
870-
public void remove(int x, int y) {
871-
remove(convToIndex(x, y));
872-
}
873-
874855
@Override
875856
public boolean isTagged(int x, int y, char key) {
876857
return isTagged(convToIndex(x, y), key);

invui/src/main/java/xyz/xenondevs/invui/gui/AbstractPagedGui.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import java.util.List;
1313
import java.util.SequencedSet;
1414
import java.util.function.BiConsumer;
15-
import java.util.function.Consumer;
1615

1716
sealed abstract class AbstractPagedGui<C>
1817
extends AbstractGui
@@ -107,9 +106,7 @@ private void updatePageContent() {
107106
List<SlotElement> slotElements = (pages != null && !pages.isEmpty()) ? pages.get(getPage()) : List.of();
108107

109108
for (int i = 0; i < contentListSlots.length; i++) {
110-
if (slotElements.size() > i)
111-
setSlotElement(contentListSlots[i], slotElements.get(i));
112-
else remove(contentListSlots[i]);
109+
setSlotElement(contentListSlots[i], slotElements.size() > i ? slotElements.get(i) : null);
113110
}
114111
}
115112

invui/src/main/java/xyz/xenondevs/invui/gui/AbstractScrollGui.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -182,8 +182,7 @@ private void updateContent() {
182182
List<SlotElement> slotElements = elements.subList(offset, Math.min(elements.size(), contentListSlots.length + offset));
183183

184184
for (int i = 0; i < contentListSlots.length; i++) {
185-
if (slotElements.size() > i) setSlotElement(contentListSlots[i], slotElements.get(i));
186-
else remove(contentListSlots[i]);
185+
setSlotElement(contentListSlots[i], slotElements.size() > i ? slotElements.get(i) : null);
187186
}
188187
}
189188

invui/src/main/java/xyz/xenondevs/invui/gui/Gui.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -380,28 +380,6 @@ static Gui single(Inventory inventory, int slot, ItemProvider background) {
380380
*/
381381
void setBackground(@Nullable ItemProvider itemProvider);
382382

383-
/**
384-
* Removes the {@link SlotElement} that is placed on that {@link Slot}.
385-
*
386-
* @param slot The slot
387-
*/
388-
void remove(Slot slot);
389-
390-
/**
391-
* Removes an {@link Item} by its coordinates.
392-
*
393-
* @param x The x coordinate
394-
* @param y The y coordinate
395-
*/
396-
void remove(int x, int y);
397-
398-
/**
399-
* Remove the {@link SlotElement} that is placed on the slot.
400-
*
401-
* @param index The slot index of the {@link SlotElement} that should be removed
402-
*/
403-
void remove(int index);
404-
405383
/**
406384
* Applies the given {@link Structure} to the {@link Gui}.
407385
*

invui/src/main/java/xyz/xenondevs/invui/gui/TabGuiImpl.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,7 @@ private void updateContent() {
101101
if (currentTab != -1) {
102102
List<SlotElement.GuiLink> slotElements = linkingElements.get(currentTab);
103103
for (int i = 0; i < contentListSlots.length; i++) {
104-
int slot = contentListSlots[i];
105-
if (slotElements != null && slotElements.size() > i)
106-
setSlotElement(contentListSlots[i], slotElements.get(i));
107-
else remove(slot);
104+
setSlotElement(contentListSlots[i], slotElements != null && slotElements.size() > i ? slotElements.get(i) : null);
108105
}
109106
} else {
110107
for (int slot : contentListSlots) {

0 commit comments

Comments
 (0)