Skip to content

Commit a0224b1

Browse files
NickCrewsclaude
andcommitted
ci: build PRs against the pinned DuckDB submodule, not the branch tip
PR CI currently overrides the submodule and checks out the tip of the matching duckdb/duckdb branch at run time. This makes PR results a function of the wall clock: a green PR turns red a week later because upstream changed, even when the PR only touches this repository. Dropping the override makes PR CI build the commit the submodule actually pins, so results are reproducible for an identical diff. Upstream drift is still caught where it has an owner: the duckdblabs bot's periodic submodule-bump PRs, whose CI now also starts testing the exact SHA they pin (previously they, too, built the moving branch tip rather than the commit being pinned). This matches duckdb-java, where PR CI builds only the vendored (pinned) engine sources and a separate Vendor workflow advances them. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 5829acc commit a0224b1

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

.github/workflows/on_pr.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ jobs:
3737
with:
3838
minimal: true
3939
testsuite: all
40-
duckdb-sha: ${{ github.base_ref }}
4140

4241
coverage_test:
4342
name: Run coverage tests
@@ -46,5 +45,4 @@ jobs:
4645
if: ${{ github.event_name == 'pull_request' && github.event.pull_request.draft == true }}
4746
uses: ./.github/workflows/coverage.yml
4847
with:
49-
duckdb_git_ref: ${{ github.base_ref }}
5048
testsuite: all

0 commit comments

Comments
 (0)