Commit a0224b1
ci: build PRs against the pinned DuckDB submodule, not the branch tip
PR CI currently overrides the submodule and checks out the tip of the
matching duckdb/duckdb branch at run time. This makes PR results a
function of the wall clock: a green PR turns red a week later because
upstream changed, even when the PR only touches this repository.
Dropping the override makes PR CI build the commit the submodule
actually pins, so results are reproducible for an identical diff.
Upstream drift is still caught where it has an owner: the duckdblabs
bot's periodic submodule-bump PRs, whose CI now also starts testing
the exact SHA they pin (previously they, too, built the moving branch
tip rather than the commit being pinned).
This matches duckdb-java, where PR CI builds only the vendored
(pinned) engine sources and a separate Vendor workflow advances them.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>1 parent 5829acc commit a0224b1
1 file changed
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | 40 | | |
42 | 41 | | |
43 | 42 | | |
| |||
46 | 45 | | |
47 | 46 | | |
48 | 47 | | |
49 | | - | |
50 | 48 | | |
0 commit comments