Skip to content

Commit ff54212

Browse files
committed
remove conversion from ParamInterpretation
1 parent 1925a9d commit ff54212

1 file changed

Lines changed: 3 additions & 6 deletions

File tree

template.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def param(value: object, name: str | None = None) -> ParamInterpolation:
9191
"""Helper function to create an IntoParam with an optional name."""
9292
if name is not None:
9393
assert_param_name_legal(name)
94-
return ParamInterpolation(value=value, expression=name, conversion=None)
94+
return ParamInterpolation(value=value, expression=name)
9595

9696

9797
def template(thing: object, /, **ignored_kwargs) -> OurTemplate:
@@ -198,7 +198,6 @@ def compile_parts(parts: Iterable[str | IntoInterpolation], /) -> CompiledSql:
198198
if passed_name := part.expression:
199199
param_name += f"_{passed_name}"
200200
sql_parts.append(f"${param_name}")
201-
# params.append({"name": param_name, "value": part.value})
202201
params.append(Param(name=param_name, value=part.value))
203202
return CompiledSql(sql="".join(sql_parts), params=tuple(params))
204203

@@ -234,12 +233,10 @@ def assert_param_name_legal(name: str) -> None:
234233
class ParamInterpolation:
235234
"""A simple implementation of IntoInterpolation, for testing purposes."""
236235

237-
def __init__(
238-
self, value: object, conversion: Literal["s", "r", "a"] | None = None, expression: str | None = None
239-
) -> None:
236+
def __init__(self, value: object, expression: str | None = None) -> None:
240237
self.value = value
241-
self.conversion = conversion
242238
self.expression = expression
239+
self.conversion = None
243240
self.format_spec = ""
244241

245242

0 commit comments

Comments
 (0)