Skip to content

Commit 3b8455c

Browse files
fabriziocuccimeta-codesync[bot]
authored andcommitted
Fix build_debugger_shell job by passing --prepack to yarn build (facebook#56005)
Summary: Pull Request resolved: facebook#56005 Changelog: [Internal] The build_debugger_shell CI job was failing because build-binary.js expects pkg.main to start with ./dist/, but without --prepack the prepack.js script never runs, so main stays as ./src/index.js. This was caused by a series of PRs: - PR facebook#54857 refactored debugger-shell/package.json to use the publishConfig pattern, moving main from ./dist/index.js to ./src/index.js. - PR facebook#55415 added the --prepack flag to build.js to support this. - PR facebook#55416 added the build_debugger_shell CI job but ran yarn build without --prepack. The fix passes --prepack to yarn build so that prepack.js rewrites package.json main to ./dist/index.js before build-binary.js runs. Reviewed By: huntie Differential Revision: D95818417 fbshipit-source-id: 03c8340c415960c3937b13bdea3952798d2d420e
1 parent 449e259 commit 3b8455c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/test-all.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -623,7 +623,7 @@ jobs:
623623
uses: ./.github/actions/yarn-install
624624
- name: Build packages
625625
shell: bash
626-
run: yarn build
626+
run: yarn build --prepack
627627
- name: Verify debugger-shell build
628628
shell: bash
629629
run: node scripts/debugger-shell/build-binary.js

0 commit comments

Comments
 (0)