Commit 4ad76b6
PreparedLayoutTextView: Don't show a selection highlight when tapping on links
Summary:
With [origins](https://github.com/facebook/litho/blob/55e28e58930a53133620fd32406ec8c3a9116c0c/litho-rendercore-text/src/main/java/com/facebook/rendercore/text/RCTextView.java#L525) in Litho's `RCTextView`, tapping a link in a `PreparedLayoutTextView` will select the link (as if keyboarding to it), before activating click, then clearing selection.
D86657563 made all pressable text links, so now we show a new native selection highlight in a lot of places.
{F1985802566}
That's a visual difference compared to before, that I am concerned might be breaking. This diff removes it, but I could be convinced it should stay. Like for keyboarding in old and new TextViews, it is using the existing `selectionColor` prop (falling back to native theme).
Changelog: [Internal]
Reviewed By: cortinico
Differential Revision: D93820112
fbshipit-source-id: 46fe33fccce0b75131f8d6dcf4aef1d175e6f3d41 parent 7de3dbe commit 4ad76b6
1 file changed
Lines changed: 0 additions & 5 deletions
File tree
- packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text
Lines changed: 0 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | 212 | | |
218 | 213 | | |
219 | 214 | | |
| |||
0 commit comments