Skip to content

Commit c2c1002

Browse files
NickGerlemanmeta-codesync[bot]
authored andcommitted
Split view conversion headers into components/view/conversions/ subdirectory (facebook#55709)
Summary: Pull Request resolved: facebook#55709 The monolithic `conversions.h` (1785 lines) and several other conversion-related headers made the view directory hard to navigate. This splits them into domain-specific files under a new `conversions/` subdirectory: - `YogaLayout.h` — Yoga float conversions, layoutMetricsFromYogaNode - `YogaStyle.h` — fromRawValue for yoga enums, convertRawProp(yoga::Style) - `Transform.h` — transform/transformOrigin parsing - `ViewStyle.h` — fromRawValue for view style enums, CascadedRectangle helpers - `Events.h` — convertRawProp(ViewEvents) - `Background.h/cpp` — background image/gradient conversions - `DebugString.h` — debug string toString overloads - `CSSPrimitives.h` — CSS color/length/angle coercion helpers - `Filter.h` — filter parsing - `BoxShadow.h` — box shadow parsing - `Accessibility.h` — accessibility trait/role/state conversions Forwarding headers are left at old paths (`conversions.h`, `accessibilityPropsConversions.h`, `propsConversions.h`) so external consumers continue to compile unchanged. Internal consumers (`BaseViewProps.cpp`, `ConversionsTest.cpp`) are updated to use the new paths directly. All file copies use `sl copy` to preserve blame history. Changelog: [Internal] Differential Revision: D94169104
1 parent 5b9b25a commit c2c1002

19 files changed

Lines changed: 3353 additions & 3236 deletions

packages/react-native/ReactCommon/react/renderer/components/view/BackgroundImagePropsConversions.h

Lines changed: 0 additions & 44 deletions
This file was deleted.

packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,9 @@
1010
#include <algorithm>
1111

1212
#include <react/featureflags/ReactNativeFeatureFlags.h>
13-
#include <react/renderer/components/view/BackgroundImagePropsConversions.h>
14-
#include <react/renderer/components/view/BoxShadowPropsConversions.h>
15-
#include <react/renderer/components/view/FilterPropsConversions.h>
1613
#include <react/renderer/components/view/conversions.h>
14+
#include <react/renderer/components/view/conversions/BoxShadow.h>
15+
#include <react/renderer/components/view/conversions/Filter.h>
1716
#include <react/renderer/components/view/primitives.h>
1817
#include <react/renderer/components/view/propsConversions.h>
1918
#include <react/renderer/core/graphicsConversions.h>

packages/react-native/ReactCommon/react/renderer/components/view/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ react_native_android_selector(platform_SRC
1515
)
1616
file(GLOB rrc_view_SRC CONFIGURE_DEPENDS
1717
*.cpp
18+
conversions/*.cpp
1819
${platform_SRC})
1920

2021
add_library(rrc_view OBJECT ${rrc_view_SRC})

0 commit comments

Comments
 (0)