Skip to content

Commit 3733bca

Browse files
Copilotnlogozzo
andauthored
fix: NativeAOT - replace reflection-based XAML bindings in SettingsPage (#117)
* Initial plan * fix: replace DisplayMemberPath with compiled x:Bind ItemTemplate for NativeAOT compatibility Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nlogozzo <17648453+nlogozzo@users.noreply.github.com>
1 parent 6970d61 commit 3733bca

1 file changed

Lines changed: 15 additions & 2 deletions

File tree

Nickvision.Application.WinUI/Views/SettingsPage.xaml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
xmlns:local="using:Nickvision.Application.WinUI.Views"
66
xmlns:nickvision="using:Nickvision.Desktop.WinUI.Controls"
77
xmlns:community="using:CommunityToolkit.WinUI.Controls"
8+
xmlns:desktopapp="using:Nickvision.Desktop.Application"
89
xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
910
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
1011
mc:Ignorable="d" Loaded="Page_Loaded">
@@ -47,15 +48,27 @@
4748
<FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}" Glyph="&#xE793;"/>
4849
</community:SettingsCard.HeaderIcon>
4950

50-
<ComboBox x:Name="CmbTheme" DisplayMemberPath="Label" SelectionChanged="Cmb_SelectionChanged"/>
51+
<ComboBox x:Name="CmbTheme" SelectionChanged="Cmb_SelectionChanged">
52+
<ComboBox.ItemTemplate>
53+
<DataTemplate x:DataType="desktopapp:ISelectionItem">
54+
<TextBlock Text="{x:Bind Label}"/>
55+
</DataTemplate>
56+
</ComboBox.ItemTemplate>
57+
</ComboBox>
5158
</community:SettingsCard>
5259

5360
<community:SettingsCard x:Name="RowTranslationLanguage">
5461
<community:SettingsCard.HeaderIcon>
5562
<FontIcon FontFamily="{StaticResource SymbolThemeFontFamily}" Glyph="&#xF2B7;"/>
5663
</community:SettingsCard.HeaderIcon>
5764

58-
<ComboBox x:Name="CmbTranslationLanguage" DisplayMemberPath="Label" SelectionChanged="Cmb_SelectionChanged"/>
65+
<ComboBox x:Name="CmbTranslationLanguage" SelectionChanged="Cmb_SelectionChanged">
66+
<ComboBox.ItemTemplate>
67+
<DataTemplate x:DataType="desktopapp:ISelectionItem">
68+
<TextBlock Text="{x:Bind Label}"/>
69+
</DataTemplate>
70+
</ComboBox.ItemTemplate>
71+
</ComboBox>
5972
</community:SettingsCard>
6073

6174
<community:SettingsCard x:Name="RowPreviewUpdates">

0 commit comments

Comments
 (0)