Merge remote-tracking branch 'origin/develop' into 3.1-stable

Author: NielBuys

application/config/user_agents.php

@@ -61,7 +61,8 @@
 $browsers = array(
 	'OPR'			=> 'Opera',
 	'Flock'			=> 'Flock',
-	'Edge'			=> 'Edge',
+	'Edge'			=> 'Edge Legacy (Spartan)',
+	'Edg'			=> 'Edge',
 	'Chrome'		=> 'Chrome',
 	// Opera 10+ always reports Opera/9.80 and appends Version/<real version> to the user agent string
 	'Opera.*?Version'	=> 'Opera',

readme.rst

@@ -10,6 +10,8 @@ interface and logical structure to access these libraries. CodeIgniter lets
 you creatively focus on your project by minimizing the amount of code needed
 for a given task.
 
+The purpose of this fork is to renew the legacy CodeIgniter 3 framework. It aims to stay current with security updates, PHP versions, and maintain backward compatibility without disrupting existing codebases.
+
 *******************
 Release Information
 *******************
@@ -20,22 +22,21 @@ https://github.com/NielBuys/CodeIgniter/releases
 Server Requirements
 *******************
 
-PHP version 7.4 or newer (PHP 8.5 ready) is recommended.
+PHP version 7.4 or newer is recommended (PHP 8.5 ready).
 
 ************
 Installation
 ************
 
-CodeIgniter is installed in four steps:
+To update an Official CodeIgniter 3 with the Fork of CodeIgniter 3
 
-1. composer require nielbuys/framework
-2. Change "codeigniter/framework" to "nielbuys/framework" in the "composer.json" file.
-3. Change in main "index.php" the following line from "$system_path = 'vendor/codeigniter/framework/system';" to "$system_path = 'vendor/nielbuys/framework/system';"
-4. Then run composer update.
+1. Change "codeigniter/framework" to "nielbuys/framework" in the "composer.json" file.
+2. Change in main "index.php" the following line from "$system_path = 'vendor/codeigniter/framework/system';" to "$system_path = 'vendor/nielbuys/framework/system';"
+3. Then run composer update.
 
-or
+CodeIgniter is installed in four steps:
 
-1. Unzip the package.
+1. Unzip the package or composer require nielbuys/framework.
 2. Upload the CodeIgniter folders and files to your server. Normally the index.php file will be at your root.
 3. Open the application/config/config.php file with a text editor and set your base URL. If you intend to use encryption or sessions, set your encryption key.
 4. If you intend to use a database, open the application/config/database.php file with a text editor and set your database settings.

system/core/Log.php

@@ -218,6 +218,7 @@ public function write_log($level, $msg)
 
 		$message .= $this->_format_line($level, $date, $msg);
 
+		$result = FALSE;
 		for ($written = 0, $length = self::strlen($message); $written < $length; $written += $result)
 		{
 			if (($result = fwrite($fp, self::substr($message, $written))) === FALSE)

system/core/Model.php

@@ -47,6 +47,7 @@
  * @author		EllisLab Dev Team
  * @link		https://codeigniter.com/userguide3/libraries/config.html
  */
+#[AllowDynamicProperties]
 class CI_Model {
 
 	/**

system/database/DB_query_builder.php

@@ -533,6 +533,10 @@ public function from($from)
 	 */
 	public function join($table, $cond, $type = '', $escape = NULL)
 	{
+		$type = (string) $type;
+		$cond = (string) $cond;
+		$table = (string) $table;
+
 		if ($type !== '')
 		{
 			$type = strtoupper(trim($type));
@@ -1208,6 +1212,9 @@ public function or_having($key, $value = NULL, $escape = NULL)
 	 */
 	public function order_by($orderby, $direction = '', $escape = NULL)
 	{
+		$orderby = (string) $orderby;
+		$direction = (string) $direction;
+
 		$direction = strtoupper(trim($direction));
 
 		if ($direction === 'RANDOM')

system/database/drivers/mysqli/mysqli_result.php

@@ -137,33 +137,39 @@ public function field_data()
 	private static function _get_field_type($type)
 	{
 		static $map;
-		isset($map) OR $map = array(
-			MYSQLI_TYPE_DECIMAL     => 'decimal',
-			MYSQLI_TYPE_BIT         => 'bit',
-			MYSQLI_TYPE_TINY        => 'tinyint',
-			MYSQLI_TYPE_SHORT       => 'smallint',
-			MYSQLI_TYPE_INT24       => 'mediumint',
-			MYSQLI_TYPE_LONG        => 'int',
-			MYSQLI_TYPE_LONGLONG    => 'bigint',
-			MYSQLI_TYPE_FLOAT       => 'float',
-			MYSQLI_TYPE_DOUBLE      => 'double',
-			MYSQLI_TYPE_TIMESTAMP   => 'timestamp',
-			MYSQLI_TYPE_DATE        => 'date',
-			MYSQLI_TYPE_TIME        => 'time',
-			MYSQLI_TYPE_DATETIME    => 'datetime',
-			MYSQLI_TYPE_YEAR        => 'year',
-			MYSQLI_TYPE_NEWDATE     => 'date',
-			MYSQLI_TYPE_INTERVAL    => 'interval',
-			MYSQLI_TYPE_ENUM        => 'enum',
-			MYSQLI_TYPE_SET         => 'set',
-			MYSQLI_TYPE_TINY_BLOB   => 'tinyblob',
-			MYSQLI_TYPE_MEDIUM_BLOB => 'mediumblob',
-			MYSQLI_TYPE_BLOB        => 'blob',
-			MYSQLI_TYPE_LONG_BLOB   => 'longblob',
-			MYSQLI_TYPE_STRING      => 'char',
-			MYSQLI_TYPE_VAR_STRING  => 'varchar',
-			MYSQLI_TYPE_GEOMETRY    => 'geometry'
-		);
+
+		if (!isset($map)) {
+			$map = array(
+				MYSQLI_TYPE_DECIMAL     => 'decimal',
+				MYSQLI_TYPE_BIT         => 'bit',
+				MYSQLI_TYPE_TINY        => 'tinyint',
+				MYSQLI_TYPE_SHORT       => 'smallint',
+				MYSQLI_TYPE_INT24       => 'mediumint',
+				MYSQLI_TYPE_LONG        => 'int',
+				MYSQLI_TYPE_LONGLONG    => 'bigint',
+				MYSQLI_TYPE_FLOAT       => 'float',
+				MYSQLI_TYPE_DOUBLE      => 'double',
+				MYSQLI_TYPE_TIMESTAMP   => 'timestamp',
+				MYSQLI_TYPE_DATE        => 'date',
+				MYSQLI_TYPE_TIME        => 'time',
+				MYSQLI_TYPE_DATETIME    => 'datetime',
+				MYSQLI_TYPE_YEAR        => 'year',
+				MYSQLI_TYPE_NEWDATE     => 'date',
+				MYSQLI_TYPE_ENUM        => 'enum',
+				MYSQLI_TYPE_SET         => 'set',
+				MYSQLI_TYPE_TINY_BLOB   => 'tinyblob',
+				MYSQLI_TYPE_MEDIUM_BLOB => 'mediumblob',
+				MYSQLI_TYPE_BLOB        => 'blob',
+				MYSQLI_TYPE_LONG_BLOB   => 'longblob',
+				MYSQLI_TYPE_STRING      => 'char',
+				MYSQLI_TYPE_VAR_STRING  => 'varchar',
+				MYSQLI_TYPE_GEOMETRY    => 'geometry'
+			);
+
+			if (defined('MYSQLI_TYPE_INTERVAL')) {
+				$map[constant('MYSQLI_TYPE_INTERVAL')] = 'interval';
+			}
+		}
 
 		return isset($map[$type]) ? $map[$type] : $type;
 	}

system/libraries/Encryption.php

@@ -475,6 +475,8 @@ protected function _openssl_encrypt($data, $params)
 			return FALSE;
 		}
 
+		$data = (string) $data;
+
 		$iv = ($iv_size = openssl_cipher_iv_length($params['handle']))
 			? $this->create_key($iv_size)
 			: '';
@@ -626,6 +628,13 @@ protected function _mcrypt_decrypt($data, $params)
 	 */
 	protected function _openssl_decrypt($data, $params)
 	{
+		if (empty($params['handle']))
+		{
+			return FALSE;
+		}
+
+		$data = (string) $data;
+
 		if ($iv_size = openssl_cipher_iv_length($params['handle']))
 		{
 			$iv = self::substr($data, 0, $iv_size);
@@ -636,15 +645,13 @@ protected function _openssl_decrypt($data, $params)
 			$iv = '';
 		}
 
-		return empty($params['handle'])
-			? FALSE
-			: openssl_decrypt(
-				$data,
-				$params['handle'],
-				$params['key'],
-				1, // DO NOT TOUCH!
-				$iv
-			);
+		return openssl_decrypt(
+			$data,
+			$params['handle'],
+			$params['key'],
+			1, // DO NOT TOUCH!
+			$iv
+		);
 	}
 
 	// --------------------------------------------------------------------