Fix remote backup location issues (TEST RELEASE v1.4.1.3)

- Fixed NFS path format handling (requires server:/export/path format)
- Improved SMB browsing with better path validation
- Fixed local location issue preventing NFS paths in local mode
- Enhanced SFTP error messages and paramiko availability handling
- Added path format hints and validation for all remote protocols
- Settings now auto-save immediately when changed
- Improved error messages with format examples

This is a TEST RELEASE to address multiple remote backup issues.

Author: Nigel

release_notes_1.4.1.3.md

@@ -0,0 +1,100 @@
+# LibreELEC Backupper v1.4.1.3 - TEST RELEASE
+
+## ⚠️ TEST RELEASE
+
+This is a **TEST RELEASE** to fix multiple remote backup location issues. Please test thoroughly before using in production.
+
+## What's New in 1.4.1.3 (December 30, 2025)
+
+### 🐛 Bug Fixes
+
+#### NFS Connection Issues
+- **Fixed NFS path format handling** - NFS now requires proper format: `server:/export/path`
+- Added automatic path format conversion and validation
+- Improved NFS mount options with soft mount and timeout settings
+- Better error messages with format examples
+
+#### SMB Browsing Issues
+- **Fixed SMB browsing** - Now properly handles manually entered paths
+- Improved SMB URL construction to handle empty username/password
+- Better path validation for SMB connections
+
+#### Local Location Issues
+- **Fixed local location with NFS path bug** - Prevents network protocols (nfs:, smb:, etc.) in local paths
+- Automatically resets invalid local paths to default location
+- Added validation to detect and prevent network protocols in local mode
+
+#### SFTP Improvements
+- **Enhanced SFTP error messages** - Better handling when paramiko module is not available
+- Improved error dialogs with solutions and alternatives
+- Still allows manual path entry even if paramiko is unavailable
+
+### 🔧 Technical Improvements
+
+- **Path Format Validation** - Added format hints and validation for all remote protocols
+- **Auto-save Settings** - Settings now save immediately when changed (no need to click OK)
+- **Better Error Messages** - All error messages now include format examples and troubleshooting tips
+- **Improved NFS Mounting** - Uses soft mount with timeout for better error handling
+
+### 📝 Path Format Examples
+
+#### NFS
+- Format: `server:/export/path`
+- Examples:
+  - `192.168.1.100:/mnt/backups`
+  - `nas.example.com:/export/share`
+
+#### SMB
+- Format: `server/share` or use Browse button
+- Examples:
+  - `192.168.1.100/backups`
+  - `server/share/subfolder`
+
+#### FTP/SFTP
+- Format: `server/path`
+- Examples:
+  - `ftp.example.com/backups`
+  - `server.example.com/home/user/backups`
+
+## Issues Fixed
+
+This release addresses multiple issues reported in GitHub:
+- Unable to back up to remote NFS location
+- SMB browsing not working with manually entered paths
+- Local location accepting NFS paths incorrectly
+- SFTP paramiko module error messages
+- Settings not applying without clicking OK
+- Missing path format hints
+
+## Testing Required
+
+Please test the following scenarios:
+1. ✅ NFS remote backup with proper format (`server:/export/path`)
+2. ✅ SMB remote backup with manually entered path
+3. ✅ SMB remote backup using Browse button
+4. ✅ Local backup location (should reject network protocols)
+5. ✅ SFTP connection (with and without paramiko)
+6. ✅ Settings auto-save functionality
+
+## Installation
+
+1. Download the test release
+2. Install through Kodi's Add-on Manager
+3. Test remote backup connections
+4. Report any issues on GitHub
+
+## Known Limitations
+
+- NFS requires the exact format `server:/export/path` (colon is required)
+- SFTP requires paramiko module for full functionality
+- Some network configurations may require additional firewall rules
+
+## Support
+
+If you encounter any issues, please:
+1. Check the [Troubleshooting Guide](https://github.com/Nigel1992/service.libreelec.backupper/wiki/Troubleshooting)
+2. Report bugs on our [Issues Page](https://github.com/Nigel1992/service.libreelec.backupper/issues)
+3. Include error messages and path formats used
+
+Thank you for testing LibreELEC Backupper!
+

service.libreelec.backupper/addon.xml

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-        <addon id="service.libreelec.backupper" name="LibreELEC Backupper" version="1.4.1.2" provider-name="Nigel">
+<addon id="service.libreelec.backupper" name="LibreELEC Backupper" version="1.4.1.3" provider-name="Nigel">
     <requires>
         <import addon="xbmc.python" version="3.0.0"/>
         <import addon="script.module.requests" version="2.22.0"/>
@@ -14,7 +14,16 @@
         <license>GPL-2.0-or-later</license>
         <forum>https://forum.libreelec.tv/</forum>
         <source>https://github.com/Nigel1992/service.libreelec.backupper</source>
-        <news>v1.4.1.2 (2025-12-30)
+        <news>v1.4.1.3 (2025-12-30) - TEST RELEASE
+- Fixed NFS connection and path format handling (requires server:/export/path format)
+- Improved SMB browsing with better path validation
+- Fixed local location issue preventing NFS paths in local mode
+- Enhanced SFTP error messages and paramiko availability handling
+- Added path format hints and validation for all remote protocols
+- Settings now auto-save immediately when changed
+- Improved error messages with format examples
+
+v1.4.1.2 (2025-12-30)
 - Fixed restore from backup failing due to read-only file system error
 - Added automatic mounting/unmounting of addons directory during restore
 - Improved path resolution for addons and repository files during restore

service.libreelec.backupper/resources/lib/backup_utils.py

@@ -63,6 +63,14 @@ def update_backup_location(self):
             self.backup_dir = self.addon.getSetting('backup_location')
             if not self.backup_dir:
                 self.backup_dir = "/storage/backup"  # Default location
+            
+            # Validate that local path doesn't contain network protocols
+            if self.backup_dir and (self.backup_dir.startswith(('nfs:', 'smb:', 'ftp:', 'sftp:', 'http:', 'https:')) or '://' in self.backup_dir):
+                xbmc.log(f"Invalid local path detected (contains network protocol): {self.backup_dir}", xbmc.LOGWARNING)
+                # Reset to default if invalid
+                self.backup_dir = "/storage/backup"
+                self.addon.setSetting('backup_location', self.backup_dir)
+                xbmc.log(f"Reset backup location to default: {self.backup_dir}", xbmc.LOGINFO)
         else:  # Remote
             # Get remote settings
             self.remote_type = int(self.addon.getSetting('remote_location_type') or "0")
@@ -137,13 +145,40 @@ def connect_remote(self):
         try:
             if self.remote_type == 0:  # SMB
                 # Use Kodi's built-in SMB support via xbmcvfs
-                remote_url = f"smb://{self.remote_username}:{urllib.parse.quote(self.remote_password)}@{self.remote_path}"
+                # Construct SMB URL properly
+                if self.remote_username and self.remote_password:
+                    remote_url = f"smb://{self.remote_username}:{urllib.parse.quote(self.remote_password)}@{self.remote_path}"
+                elif self.remote_username:
+                    remote_url = f"smb://{self.remote_username}@{self.remote_path}"
+                else:
+                    remote_url = f"smb://{self.remote_path}"
+                
                 self.remote_connection = remote_url
                 # Test connection by trying to list directory
                 dirs, files = xbmcvfs.listdir(remote_url)
                 return True
 
             elif self.remote_type == 1:  # NFS
+                # Validate and format NFS path
+                # NFS requires format: server:/export/path or server:/export
+                nfs_path = self.remote_path.strip()
+                
+                # Check if path already has the correct format (contains :/)
+                if ':/' not in nfs_path:
+                    # Try to convert IP or hostname to proper NFS format
+                    # If it's just an IP or hostname, we need the export path
+                    if '/' not in nfs_path:
+                        xbmc.log(f"Invalid NFS path format: {nfs_path}. Expected format: server:/export/path", xbmc.LOGERROR)
+                        return False
+                    # If it has / but no :, assume it's server/export format and convert
+                    if ':' not in nfs_path:
+                        parts = nfs_path.split('/', 1)
+                        if len(parts) == 2:
+                            nfs_path = f"{parts[0]}:/{parts[1]}"
+                        else:
+                            xbmc.log(f"Invalid NFS path format: {nfs_path}. Expected format: server:/export/path", xbmc.LOGERROR)
+                            return False
+                
                 # Mount NFS share
                 mount_point = os.path.join(self.backup_dir, "nfs_mount")
                 if not os.path.exists(mount_point):
@@ -152,13 +187,21 @@ def connect_remote(self):
                 # Unmount if already mounted
                 subprocess.call(["umount", mount_point], stderr=subprocess.DEVNULL)
 
-                # Mount the NFS share
-                result = subprocess.call(["mount", "-t", "nfs", self.remote_path, mount_point])
+                # Mount the NFS share with proper options
+                # Use soft mount and shorter timeout for better error handling
+                mount_options = ["-t", "nfs", "-o", "soft,timeo=10,retrans=2"]
+                result = subprocess.call(["mount"] + mount_options + [nfs_path, mount_point], 
+                                        stderr=subprocess.PIPE, stdout=subprocess.PIPE)
+                
                 if result == 0:
                     self.remote_connection = mount_point
+                    xbmc.log(f"Successfully mounted NFS share: {nfs_path} to {mount_point}", xbmc.LOGINFO)
                     return True
                 else:
-                    xbmc.log(f"Failed to mount NFS share: {self.remote_path}", xbmc.LOGERROR)
+                    error_msg = f"Failed to mount NFS share: {nfs_path}. "
+                    error_msg += "Please verify: 1) NFS server is running, 2) Export path is correct (format: server:/export/path), "
+                    error_msg += "3) Network connectivity, 4) NFS client is installed"
+                    xbmc.log(error_msg, xbmc.LOGERROR)
                     return False
 
             elif self.remote_type == 2:  # FTP