[KeyBot] improve: standardize argument guards in Authorization ServiceCollectionExtensions#258
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…onExtensions Replace verbose if/throw null-check patterns with modern ArgumentNullException.ThrowIfNull and ArgumentException.ThrowIfNullOrEmpty helpers throughout ServiceCollectionExtensions in the Authorization project. This aligns with the pattern already used in the first AddKeycloakAuthorization overload and reduces boilerplate. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
automation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by KeyBot, an automated AI assistant.
Summary
Replaces verbose
if (x is null) { throw new ArgumentNullException(nameof(x)); }patterns with modernArgumentNullException.ThrowIfNullandArgumentException.ThrowIfNullOrEmptyhelpers inServiceCollectionExtensions(Authorization project).Motivation
The first overload of
AddKeycloakAuthorizationalready used the modern throw-helper pattern; the remaining overloads andAddAuthorizationServer/AddAuthorizationServerClientstill used the old verbose guards. This aligns the whole file with the idiomatic .NET 7+ style, reduces boilerplate, and makes the intent immediately clear.Changes
AddKeycloakAuthorization(IConfigurationSection)— replaced twoif/throwblocks withArgumentNullException.ThrowIfNullAddKeycloakAuthorization(Action<>)— replaced oneif/throwblockAddKeycloakAuthorization(IConfiguration, string)— replaced thestring.IsNullOrEmptyguard withArgumentException.ThrowIfNullOrEmptyAddAuthorizationServer(IConfiguration, ...)— replaced two null checks + one string checkAddAuthorizationServer(IConfigurationSection, ...)— replaced two null checksAddAuthorizationServer(Action<>, ...)— replaced one null checkAddAuthorizationServerClient— replaced one null checkTest Status
✅ Build:
dotnet build -p:WarningLevel=0 /clp:ErrorsOnly— succeeded✅ Unit tests:
dotnet cake --target=Test— 155 passed, 0 failed⏭️ Integration tests: skipped (requires Docker/Testcontainers)