test(invariants): enforce fail_on_revert and add nightly Foundry profile + workflow#29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://app.asana.com/0/1213822431665320/1214550187808659
Tunes the Foundry invariant config in two ways:
fail_on_revert = trueon the default profile. Previously handler reverts were silently discarded, so unexpected reverts in our invariant suite were invisible. Both existing handlers (StakingHandler,HeartbeatHandler) already guard preconditions with earlyreturns, so flipping this is non-disruptive — verified locally with 0 reverts at default settings (256×500) and at 8× scale (500×1000).nightlyprofile withruns=2500, depth=1500(~25× the default search space) so longer random sequences get explored without slowing PR CI.Adds a
nightly-invariants.ymlGitHub Actions workflow that runs the invariant suite withFOUNDRY_PROFILE=nightlydaily at 03:00 UTC (alsoworkflow_dispatch).