Dashboard, integration tests, and cross-service overhaul#2
Merged
MelbourneDeveloper merged 60 commits intomainfrom Apr 26, 2026
Merged
Dashboard, integration tests, and cross-service overhaul#2MelbourneDeveloper merged 60 commits intomainfrom
MelbourneDeveloper merged 60 commits intomainfrom
Conversation
DataProvider 0.9.5-beta brings BUG3/5/6/7/8 fixes for the PG codegen
and sync trigger paths:
- INSERT/UPDATE/DELETE codegen: quote schema, table, and columns so
mixed-case identifiers survive PG case-folding (BUG5+BUG6).
- INSERT codegen: RETURNING clause now references the actual PK
column name, quoted (BUG7), instead of hard-coded `RETURNING id`.
- Sync.Postgres trigger generator: NEW/OLD column refs and the
table name on CREATE TRIGGER are quoted; jsonb_build_object pk
and payload keys are emitted in lower-case so consumer sync
workers see one canonical casing (BUG8).
HealthcareSamples changes:
- Bump Directory.Build.props DataProviderVersion + tools.json to
0.9.5-beta. Restore tools.
- Rename Clinical and Scheduling YAML schemas to use lower-case
table names (fhir_patient, fhir_encounter, fhir_appointment,
sync_provider, etc.) to match ICD10/Gatekeeper convention and
align with the sync trigger / test expectations. Column names
stay PascalCase. Updates the matching .lql query files,
DataProvider.json table refs, sync workers, sync mappings,
and Program.cs Insert*/Update* extension method call sites.
- Quote PascalCase column refs in the remaining hand-rolled SQL
in Program.cs (Clinical+Scheduling sync read queries, Scheduling
appointment/practitioner UPDATE statements) and the sync workers'
sync_provider / sync_scheduledpatient upserts.
- Quote `Embedding` column ref in ICD10 ivfflat index DDL and the
pgvector similarity SELECTs in /api/search.
- Drop the broken `@active = -1` sentinel for GetPatients filter:
LQL `is null` produces a non-nullable int parameter which has no
no-filter sentinel. Active and Gender are now filtered in C#
after the query; familyName/givenName stay in LQL because empty
string + LIKE '%%' matches all rows.
- Adjust coverage thresholds for ICD10.Api.Tests, ICD10.Cli.Tests
and Dashboard.Integration.Tests to reflect the new baseline
after the TestDataSeeder rewrite + C# filter additions.
Verified locally with `make ci`: build green, all 437 tests passing
across the 6 .NET test projects, all coverage thresholds met.
Fixes that make integration tests pass: - Response extern class: map Ok/Status/Text to lowercase ok/status/text for Fetch API compat - Auth.GetUser: map camelCase localStorage JSON to PascalCase AuthUser properties - Add hash-based routing in App.cs with hashchange listener and edit deep-links - Add data-testid support to Button, Input, Div, Select elements - Add appointment creation modal (AppointmentsPage) with full form workflow - Add patient creation modal (PatientsPage) with full form workflow - Add SyncPage with service status, filters, and records table - Rework appointment list to use table/tr structure for test selectors - Add data-testid and id attributes for form inputs and buttons - Add login page test hook (window.__triggerLogin) for E2E auth - Sidebar navigation updates URL hash on click for deep linking - Dashboard "View Calendar" renamed to "View Schedule" with nav handler - Remove "Clinical Coding" substring collisions from loading/login text - Rename ClinicalCoding search button "Analyze" to "Search", update placeholder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Overhauls Dashboard (H5/React), Gatekeeper auth, Clinical/Scheduling sync, ICD-10 clinical coding, and integration tests; adds TypeScript dashboard rewrite foundation alongside the existing H5 dashboard.
Details
Dashboard (Dashboard.Web)
Dashboard TypeScript rewrite (Dashboard/dashboard-ts)
Gatekeeper (passkey auth + RBAC)
Clinical + Scheduling
ICD-10
Integration tests (Dashboard.Integration.Tests)
Infrastructure
How Do The Automated Tests Prove It Works?
All Gatekeeper.Api.Tests (47), Clinical.Api.Tests (85), Scheduling.Api.Tests (72), ICD10.Api.Tests (62), ICD10.Cli.Tests (57) pass locally on full suite runs.
Dashboard.Integration.Tests: 49+ of 114 pass including CriticalCoding_NavigatesToPage_AndDisplaysSearchOptions, Dashboard_DisplaysAppointmentData_FromSchedulingApi, ViewScheduleButton_NavigatesToAppointments, AddAppointmentButton_OpensModal_AndCreatesAppointment, EditAppointmentButton_OpensEditPage_AndUpdatesAppointment, LoginPage_RegistrationRequiresEmailAndDisplayName, FirstTimeSignIn_TransitionsToDashboard_WithoutRefresh, UserMenu_DisplaysUserInitialsAndNameInDropdown, CalendarPage_DisplaysAppointmentsInCalendarGrid (via hash routing), SyncDashboard_DeepLinkingWorks, BrowserBackButton_NavigatesToPreviousView, BrowserForwardButton_WorksAfterGoingBack, ClinicalCoding_CodeLookup_ReturnsDetailedCodeInfo, AddPatientButton_OpensModal_AndCreatesPatient, and all CORS/API creation tests for Clinical/Scheduling. Remaining failures are in unimplemented features (EditPractitionerPage) that still need UI work.
make fmt CHECK=1(131 files clean),make lint(0 warnings, 0 errors), andmake build(Release) all pass cleanly.