Linting fixes

Author: MelbourneDeveloper

.vscodeignore

@@ -6,7 +6,7 @@ test-fixtures/**
 out/test/**
 node_modules/**
 !node_modules/node-sqlite3-wasm/**
-scripts/**
+tools/**
 .too_many_cooks/**
 .claude/**
 .github/**

CONTRIBUTING.md

@@ -0,0 +1,37 @@
+# Contributing to CommandTree
+
+## Prerequisites
+
+- Node.js (LTS)
+- VS Code
+
+## Setup
+
+```bash
+npm install
+```
+
+## CI Gate
+
+Before submitting a pull request, you **must** run:
+
+```bash
+make ci
+```
+
+This runs formatting, linting, building, testing (with coverage check), and packaging. All steps must pass. Pull requests that fail `make ci` will not be merged.
+
+## Make Targets
+
+| Target | Description |
+|--------|-------------|
+| `make format` | Format source with Prettier |
+| `make lint` | Lint with ESLint |
+| `make build` | Compile TypeScript |
+| `make test` | Run unit tests, e2e tests with coverage, and coverage threshold check |
+| `make package` | Build VSIX package |
+| `make ci` | Run all of the above in sequence |
+
+## Coverage
+
+Tests enforce a 90% coverage threshold on lines, functions, branches, and statements. The coverage check runs automatically as part of `make test`.

Claude.md

@@ -1,5 +1,7 @@
 # CLAUDE.md - CommandTree Extension
 
+⚠️ CRITICAL: **Reduce token usage.** Check file size before loading. Write less. Delete fluff and dead code. Alert user when context is loaded with pointless files. ⚠️ 
+
 ## Too Many Cooks
 
 You are working with many other agents. Make sure there is effective cooperation

Makefile

@@ -15,9 +15,11 @@ package: build
 test: build
 	npm run test:unit
 	npx vscode-test --coverage
+	node tools/check-coverage.mjs
 
 test-exclude-ci: build
 	npm run test:unit
 	npx vscode-test --coverage --grep @exclude-ci --invert
+	node tools/check-coverage.mjs
 
 ci: format lint build test package

README.md

@@ -83,6 +83,10 @@ Open a workspace and the CommandTree panel appears in the sidebar. All discovere
 | `commandtree.excludePatterns` | Glob patterns to exclude from discovery | `**/node_modules/**`, `**/.git/**`, etc. |
 | `commandtree.sortOrder` | Sort commands by `folder`, `name`, or `type` | `folder` |
 
+## Contributing
+
+See [CONTRIBUTING.md](CONTRIBUTING.md) for development setup and guidelines. All pull requests must pass `make ci` before merging.
+
 ## License
 
 [MIT](LICENSE)

package.json

@@ -382,7 +382,7 @@
     "test:unit": "mocha out/test/unit/**/*.test.js",
     "test:e2e": "vscode-test",
     "test:coverage": "vscode-test --coverage",
-    "coverage:check": "node scripts/check-coverage.mjs",
+    "coverage:check": "node tools/check-coverage.mjs",
     "clean": "rm -rf node_modules out *.vsix coverage || true",
     "package": "npm run compile && vsce package",
     "uninstall": "code --uninstall-extension nimblesite.commandtree || true",

scripts/convert-icon.py

@@ -6,111 +6,116 @@ export interface MiseTask {
   params: ParamDef[];
 }
 
+function parseTomlTaskHeader(trimmed: string): string | undefined {
+  const match = /^\[tasks\.([^\]]+)\]$/.exec(trimmed);
+  return match?.[1];
+}
+
+function parseTomlDescription(trimmed: string): string | undefined {
+  const match = /^description\s*=\s*"([^"]*)"/.exec(trimmed);
+  return match?.[1];
+}
+
+function finishTask(tasks: MiseTask[], current: MiseTask | null): void {
+  if (current !== null) {
+    tasks.push(current);
+  }
+}
+
 /**
  * Parses TOML format mise configuration.
  */
 export function parseMiseToml(content: string): MiseTask[] {
   const tasks: MiseTask[] = [];
-
   const lines = content.split("\n");
   let currentTask: MiseTask | null = null;
 
   for (const line of lines) {
     const trimmed = line.trim();
 
-    // [tasks.name] sections are self-identifying — no [tasks] preamble needed
     if (trimmed.startsWith("[tasks.")) {
-      if (currentTask !== null) {
-        tasks.push(currentTask);
-        currentTask = null;
-      }
-
-      const match = /^\[tasks\.([^\]]+)\]$/.exec(trimmed);
-      if (match !== null && match[1] !== undefined) {
-        currentTask = {
-          name: match[1],
-          params: [],
-        };
-      }
+      finishTask(tasks, currentTask);
+      const name = parseTomlTaskHeader(trimmed);
+      currentTask = name !== undefined ? { name, params: [] } : null;
       continue;
     }
 
-    // Any other section header ends the current task
     if (trimmed.startsWith("[")) {
-      if (currentTask !== null) {
-        tasks.push(currentTask);
-        currentTask = null;
-      }
+      finishTask(tasks, currentTask);
+      currentTask = null;
       continue;
     }
 
-    // Extract description from current task
     if (currentTask !== null && trimmed.startsWith("description")) {
-      const descMatch = /^description\s*=\s*"([^"]*)"/.exec(trimmed);
-      if (descMatch !== null && descMatch[1] !== undefined) {
-        currentTask.description = descMatch[1];
+      const desc = parseTomlDescription(trimmed);
+      if (desc !== undefined) {
+        currentTask.description = desc;
       }
     }
   }
 
-  if (currentTask !== null) {
-    tasks.push(currentTask);
+  finishTask(tasks, currentTask);
+  return tasks;
+}
+
+function parseYamlTaskName(line: string): string | undefined {
+  const match = /^\s+([^:]+):\s*$/.exec(line);
+  return match?.[1]?.trim();
+}
+
+function parseYamlDescription(line: string): string | undefined {
+  const match = /^\s+description:\s*["]?([^"]*)["]?\s*$/.exec(line);
+  return match?.[1];
+}
+
+function isSkippableLine(trimmed: string): boolean {
+  return trimmed === "" || trimmed.startsWith("#");
+}
+
+function processYamlTaskLine(tasks: MiseTask[], line: string, indent: number): void {
+  if (indent === 2 && !line.trim().startsWith("-") && line.includes(":")) {
+    const name = parseYamlTaskName(line);
+    if (name !== undefined) {
+      tasks.push({ name, params: [] });
+    }
+    return;
   }
 
-  return tasks;
+  if (indent > 2 && line.includes("description:")) {
+    const desc = parseYamlDescription(line);
+    const lastTask = tasks[tasks.length - 1];
+    if (desc !== undefined && lastTask !== undefined) {
+      lastTask.description = desc;
+    }
+  }
 }
 
 /**
  * Parses YAML format mise configuration.
  */
 export function parseMiseYaml(content: string): MiseTask[] {
   const tasks: MiseTask[] = [];
-
   const lines = content.split("\n");
   let inTasks = false;
 
   for (const line of lines) {
-    // Skip empty lines and comments
-    if (line.trim() === "" || line.trim().startsWith("#")) {
+    if (isSkippableLine(line.trim())) {
       continue;
     }
 
-    // Get indent level
     const indent = line.search(/\S/);
 
-    // Check for "tasks:" at root level
     if (indent === 0 && line.trim() === "tasks:") {
       inTasks = true;
       continue;
     }
 
-    // Exit tasks section if we hit another root-level key
-    if (inTasks && indent === 0 && !line.trim().startsWith("tasks:")) {
+    if (inTasks && indent === 0) {
       inTasks = false;
     }
 
     if (inTasks && indent > 0) {
-      // Task name line (immediate child of tasks)
-      if (indent === 2 && !line.trim().startsWith("-") && line.includes(":")) {
-        const match = /^\s+([^:]+):\s*$/.exec(line);
-        if (match !== null && match[1] !== undefined) {
-          tasks.push({
-            name: match[1].trim(),
-            params: [],
-          });
-        }
-      }
-
-      // Description line (child of task)
-      if (indent > 2 && line.includes("description:")) {
-        const descMatch = /^\s+description:\s*["]?([^"]*)["]?\s*$/.exec(line);
-        if (descMatch !== null && descMatch[1] !== undefined && tasks.length > 0) {
-          const lastTask = tasks[tasks.length - 1];
-          if (lastTask !== undefined) {
-            lastTask.description = descMatch[1];
-          }
-        }
-      }
+      processYamlTaskLine(tasks, line, indent);
     }
   }