[BUG8] Lower-case JSON keys in PG sync trigger payload + 0.9.5-beta

Follow-up to BUG8 0.9.4-beta. The trigger emitted JSON keys verbatim
from column names (e.g. 'GivenName', 'NameFamily'), but downstream
consumers (sync workers, integration tests) read keys via lower-case
('givenname', 'namefamily'). KeyNotFoundException at runtime.

Fix: lower-case the JSON key in BuildJsonbObject and in the pk_value
extraction (jsonb_build_object('{pkLower}', NEW."{pkColumn}")). The
SQL identifier reference still uses NEW."OriginalCase" so the
trigger function executes against the real PG column; only the JSON
key emitted into the payload is lower-cased so consumers see one
canonical casing regardless of source schema.

Verified: Sync tests 246/246 still pass.

Bumps Directory.Build.props Version to 0.9.5-beta.

Author: Christian Findlay

Directory.Build.props

@@ -4,7 +4,7 @@
     <NuGetAudit>false</NuGetAudit>
     <NuGetAuditMode>disabled</NuGetAuditMode>
     <RestoreAuditProperties>false</RestoreAuditProperties>
-    <Version>0.9.4-beta</Version>
+    <Version>0.9.5-beta</Version>
     <Authors>ChristianFindlay</Authors>
     <Company>MelbourneDeveloper</Company>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>

Sync/Nimblesite.Sync.Postgres/PostgresTriggerGenerator.cs

@@ -281,6 +281,7 @@ string pkColumn
     )
     {
         var lowerTable = tableName.ToLowerInvariant();
+        var pkLower = pkColumn.ToLowerInvariant();
         return string.Format(
             CultureInfo.InvariantCulture,
             """
@@ -290,7 +291,7 @@ string pkColumn
                     INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timestamp)
                     VALUES (
                         '{1}',
-                        jsonb_build_object('{2}', NEW."{2}")::text,
+                        jsonb_build_object('{4}', NEW."{2}")::text,
                         'insert',
                         {3}::text,
                         (SELECT value FROM _sync_state WHERE key = 'origin_id'),
@@ -309,7 +310,8 @@ AFTER INSERT ON "{1}"
             lowerTable,
             tableName,
             pkColumn,
-            BuildJsonbObject(columns, "NEW")
+            BuildJsonbObject(columns, "NEW"),
+            pkLower
         );
     }
 
@@ -320,6 +322,7 @@ string pkColumn
     )
     {
         var lowerTable = tableName.ToLowerInvariant();
+        var pkLower = pkColumn.ToLowerInvariant();
         return string.Format(
             CultureInfo.InvariantCulture,
             """
@@ -329,7 +332,7 @@ string pkColumn
                     INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timestamp)
                     VALUES (
                         '{1}',
-                        jsonb_build_object('{2}', NEW."{2}")::text,
+                        jsonb_build_object('{4}', NEW."{2}")::text,
                         'update',
                         {3}::text,
                         (SELECT value FROM _sync_state WHERE key = 'origin_id'),
@@ -348,13 +351,15 @@ AFTER UPDATE ON "{1}"
             lowerTable,
             tableName,
             pkColumn,
-            BuildJsonbObject(columns, "NEW")
+            BuildJsonbObject(columns, "NEW"),
+            pkLower
         );
     }
 
     private static string GenerateDeleteTrigger(string tableName, string pkColumn)
     {
         var lowerTable = tableName.ToLowerInvariant();
+        var pkLower = pkColumn.ToLowerInvariant();
         return string.Format(
             CultureInfo.InvariantCulture,
             """
@@ -364,7 +369,7 @@ private static string GenerateDeleteTrigger(string tableName, string pkColumn)
                     INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timestamp)
                     VALUES (
                         '{1}',
-                        jsonb_build_object('{2}', OLD."{2}")::text,
+                        jsonb_build_object('{3}', OLD."{2}")::text,
                         'delete',
                         NULL,
                         (SELECT value FROM _sync_state WHERE key = 'origin_id'),
@@ -382,17 +387,23 @@ AFTER DELETE ON "{1}"
             """,
             lowerTable,
             tableName,
-            pkColumn
+            pkColumn,
+            pkLower
         );
     }
 
     // BUG8 fix: quote column names in jsonb_build_object payload so triggers
     // work on tables with mixed-case column names (e.g. "GivenName"). Without
     // the surrounding " quotes, PG case-folds NEW.GivenName to NEW.givenname
     // and the trigger fires `record "new" has no field "givenname"`.
+    //
+    // The emitted JSON key is the column name lower-cased so downstream
+    // consumers see a single canonical casing regardless of how the schema
+    // declared the column. The PG identifier (NEW."ColName") preserves case
+    // so the trigger function compiles + executes against the real column.
     private static string BuildJsonbObject(IReadOnlyList<string> columns, string prefix)
     {
-        var pairs = columns.Select(c => $"'{c}', {prefix}.\"{c}\"");
+        var pairs = columns.Select(c => $"'{c.ToLowerInvariant()}', {prefix}.\"{c}\"");
         return $"jsonb_build_object({string.Join(", ", pairs)})";
     }
 }