[BUG8] Quote NEW/OLD column refs + table name in PG sync trigger + 0.9.4-beta

PostgresTriggerGenerator emitted `NEW.{column}` / `OLD.{column}`
without surrounding double-quotes in the generated trigger function
body. Postgres case-folds unquoted identifiers to lowercase, so when
a table has mixed-case columns (e.g. fhir_patient."GivenName") the
trigger fires:

  ERROR: 42703: record "new" has no field "givenname"

and the originating INSERT/UPDATE/DELETE on the source table fails
with HTTP 500.

Same root as BUG3/BUG6/BUG7: every emitted SQL identifier needs to
be wrapped in " so it survives PG case-folding.

Fix:
- Quote NEW."{pkColumn}" / OLD."{pkColumn}" in jsonb_build_object
  pk_value extraction (insert/update/delete trigger functions).
- Quote NEW."{c}" in BuildJsonbObject for the full payload.
- Quote the table name in CREATE TRIGGER ... ON "{tableName}" and in
  the matching DROP TRIGGER IF EXISTS so triggers attach to mixed-
  case tables too.

Verified: Sync tests 246/246 pass.

Bumps Directory.Build.props Version to 0.9.4-beta.

Author: Christian Findlay

Directory.Build.props

@@ -4,7 +4,7 @@
     <NuGetAudit>false</NuGetAudit>
     <NuGetAuditMode>disabled</NuGetAuditMode>
     <RestoreAuditProperties>false</RestoreAuditProperties>
-    <Version>0.9.3-beta</Version>
+    <Version>0.9.4-beta</Version>
     <Authors>ChristianFindlay</Authors>
     <Company>MelbourneDeveloper</Company>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>

Sync/Nimblesite.Sync.Postgres/PostgresTriggerGenerator.cs

@@ -290,7 +290,7 @@ string pkColumn
                     INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timestamp)
                     VALUES (
                         '{1}',
-                        jsonb_build_object('{2}', NEW.{2})::text,
+                        jsonb_build_object('{2}', NEW."{2}")::text,
                         'insert',
                         {3}::text,
                         (SELECT value FROM _sync_state WHERE key = 'origin_id'),
@@ -301,9 +301,9 @@ INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timesta
             END;
             $$ LANGUAGE plpgsql;
 
-            DROP TRIGGER IF EXISTS {0}_sync_insert ON {1};
+            DROP TRIGGER IF EXISTS {0}_sync_insert ON "{1}";
             CREATE TRIGGER {0}_sync_insert
-            AFTER INSERT ON {1}
+            AFTER INSERT ON "{1}"
             FOR EACH ROW EXECUTE FUNCTION {0}_sync_insert_fn();
             """,
             lowerTable,
@@ -329,7 +329,7 @@ string pkColumn
                     INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timestamp)
                     VALUES (
                         '{1}',
-                        jsonb_build_object('{2}', NEW.{2})::text,
+                        jsonb_build_object('{2}', NEW."{2}")::text,
                         'update',
                         {3}::text,
                         (SELECT value FROM _sync_state WHERE key = 'origin_id'),
@@ -340,9 +340,9 @@ INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timesta
             END;
             $$ LANGUAGE plpgsql;
 
-            DROP TRIGGER IF EXISTS {0}_sync_update ON {1};
+            DROP TRIGGER IF EXISTS {0}_sync_update ON "{1}";
             CREATE TRIGGER {0}_sync_update
-            AFTER UPDATE ON {1}
+            AFTER UPDATE ON "{1}"
             FOR EACH ROW EXECUTE FUNCTION {0}_sync_update_fn();
             """,
             lowerTable,
@@ -364,7 +364,7 @@ private static string GenerateDeleteTrigger(string tableName, string pkColumn)
                     INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timestamp)
                     VALUES (
                         '{1}',
-                        jsonb_build_object('{2}', OLD.{2})::text,
+                        jsonb_build_object('{2}', OLD."{2}")::text,
                         'delete',
                         NULL,
                         (SELECT value FROM _sync_state WHERE key = 'origin_id'),
@@ -375,9 +375,9 @@ INSERT INTO _sync_log (table_name, pk_value, operation, payload, origin, timesta
             END;
             $$ LANGUAGE plpgsql;
 
-            DROP TRIGGER IF EXISTS {0}_sync_delete ON {1};
+            DROP TRIGGER IF EXISTS {0}_sync_delete ON "{1}";
             CREATE TRIGGER {0}_sync_delete
-            AFTER DELETE ON {1}
+            AFTER DELETE ON "{1}"
             FOR EACH ROW EXECUTE FUNCTION {0}_sync_delete_fn();
             """,
             lowerTable,
@@ -386,9 +386,13 @@ AFTER DELETE ON {1}
         );
     }
 
+    // BUG8 fix: quote column names in jsonb_build_object payload so triggers
+    // work on tables with mixed-case column names (e.g. "GivenName"). Without
+    // the surrounding " quotes, PG case-folds NEW.GivenName to NEW.givenname
+    // and the trigger fires `record "new" has no field "givenname"`.
     private static string BuildJsonbObject(IReadOnlyList<string> columns, string prefix)
     {
-        var pairs = columns.Select(c => $"'{c}', {prefix}.{c}");
+        var pairs = columns.Select(c => $"'{c}', {prefix}.\"{c}\"");
         return $"jsonb_build_object({string.Join(", ", pairs)})";
     }
 }