-
-
Notifications
You must be signed in to change notification settings - Fork 985
Add view-tracking pixels to README and notebooks #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -448,6 +448,13 @@ | |
| "print(\"Final Instruction Output:\")\n", | ||
| "print(get_completion(final_instruction))" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "" | ||
| ] | ||
|
Comment on lines
+452
to
+457
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add explicit tracking disclosure/consent before embedding remote view pixels. Line 456 introduces a third-party tracking request on notebook render, which can collect visitor metadata (e.g., IP/user-agent/referrer) without an explicit notice. Please add a visible privacy disclosure (and ideally an opt-out mechanism) where these pixels are introduced, or gate tracking behind explicit consent. 🤖 Prompt for AI Agents |
||
| } | ||
| ], | ||
| "metadata": { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -413,6 +413,13 @@ | |
| "\n", | ||
| "run_security_tests()" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "" | ||
| ] | ||
|
Comment on lines
+417
to
+422
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add explicit disclosure/consent for passive tracking pixels. This hidden pixel causes automatic outbound requests on notebook render and can collect user metadata (e.g., IP/UA/referrer) without an in-repo disclosure or opt-out path. Please add a visible privacy notice and documented opt-out before rollout. 🤖 Prompt for AI Agents |
||
| } | ||
| ], | ||
| "metadata": { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add explicit tracking disclosure for the README view pixel.
Line 384 introduces passive analytics collection from a remote endpoint. Please add a short privacy notice in the README (what is collected, purpose, and how users can avoid it) so this is transparent and compliant with common OSS privacy expectations.
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 384-384: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents
Provide alt text for the tracker image.
Line 384 uses an image with empty alt text; this fails markdown accessibility linting and is easy to fix.
Proposed fix
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 384-384: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents
Source: Linters/SAST tools