Skip to content

Commit 4450b2c

Browse files
Socratic Developerclaude
andcommitted
fix: Fix ruff linting errors and missing imports in socratic-docs
Changes: - Fix __init__.py: Import MultiFileCodeSplitter (not MultiFileSplitter) - Add missing imports: * artifact_saver.py: Add LanguageExtractorRegistry import * multi_file_splitter.py: Add LanguageExtractorRegistry and ProjectTemplateGenerator imports - Fix ambiguous variable names: * code_extractor.py: Replace 'l' with 'line' in list comprehensions * extractors/base.py: Replace 'l' with 'line' in list comprehensions - Sort imports with ruff --fix - Remove unused imports All ruff checks now pass. Module imports successfully. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
1 parent eb0b064 commit 4450b2c

8 files changed

Lines changed: 23 additions & 18 deletions

File tree

src/socratic_docs/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
from .documentation_generator import DocumentationGenerator
1212
from .git_initializer import GitInitializer
1313
from .git_repository_manager import GitRepositoryManager
14-
from .multi_file_splitter import MultiFileSplitter
14+
from .multi_file_splitter import MultiFileCodeSplitter
1515
from .project_templates import ProjectTemplate
1616

1717
__version__ = "0.2.0"
@@ -21,6 +21,6 @@
2121
"DocumentationGenerator",
2222
"GitInitializer",
2323
"GitRepositoryManager",
24-
"MultiFileSplitter",
24+
"MultiFileCodeSplitter",
2525
"ProjectTemplate",
2626
]

src/socratic_docs/artifact_saver.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@
1111
from datetime import datetime
1212
from pathlib import Path
1313

14+
from .extractors import LanguageExtractorRegistry
15+
1416
logger = logging.getLogger("socrates.utils.artifact_saver")
1517

1618

src/socratic_docs/code_extractor.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
- Solution: Extract actual Python code from markdown before processing
1111
"""
1212

13-
import re
1413
import ast
1514
import logging
16-
from typing import Tuple, Optional, List
15+
import re
16+
from typing import Optional, Tuple
1717

1818
logger = logging.getLogger(__name__)
1919

@@ -220,14 +220,14 @@ def get_code_statistics(content: str) -> dict:
220220
Dictionary with code statistics
221221
"""
222222
lines = content.split("\n")
223-
code_lines = [l for l in lines if l.strip() and not l.strip().startswith("#")]
224-
comment_lines = [l for l in lines if l.strip().startswith("#")]
223+
code_lines = [line for line in lines if line.strip() and not line.strip().startswith("#")]
224+
comment_lines = [line for line in lines if line.strip().startswith("#")]
225225

226226
stats = {
227227
"total_lines": len(lines),
228228
"code_lines": len(code_lines),
229229
"comment_lines": len(comment_lines),
230-
"blank_lines": len([l for l in lines if not l.strip()]),
230+
"blank_lines": len([line for line in lines if not line.strip()]),
231231
"is_valid_python": CodeExtractor.validate_python_syntax(content)[0],
232232
}
233233

src/socratic_docs/extractors/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
"""
2626

2727
from .base import BaseLanguageExtractor
28-
from .models import ValidationResult, ExtractionResult
29-
from .registry import LanguageExtractorRegistry, LanguageExtractorMetadata
30-
from .python_extractor import PythonExtractor
3128
from .generic_extractor import GenericExtractor
29+
from .models import ExtractionResult, ValidationResult
30+
from .python_extractor import PythonExtractor
31+
from .registry import LanguageExtractorMetadata, LanguageExtractorRegistry
3232

3333
__all__ = [
3434
"BaseLanguageExtractor",

src/socratic_docs/extractors/base.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
Defines the interface that all language extractors must implement.
55
"""
66

7-
import re
87
import logging
8+
import re
99
from abc import ABC, abstractmethod
10-
from typing import List, Optional
10+
from typing import List
1111

12-
from .models import ValidationResult, ExtractionResult
12+
from .models import ExtractionResult, ValidationResult
1313

1414
logger = logging.getLogger(__name__)
1515

@@ -271,8 +271,8 @@ def get_code_statistics(self, code: str) -> dict:
271271
Dictionary with line counts and validity
272272
"""
273273
lines = code.split("\n")
274-
code_lines = [l for l in lines if l.strip() and not l.strip().startswith("#")]
275-
comment_lines = [l for l in lines if l.strip().startswith("#")]
274+
code_lines = [line for line in lines if line.strip() and not line.strip().startswith("#")]
275+
comment_lines = [line for line in lines if line.strip().startswith("#")]
276276

277277
validation = self.validate_syntax(code)
278278

@@ -281,6 +281,6 @@ def get_code_statistics(self, code: str) -> dict:
281281
"total_lines": len(lines),
282282
"code_lines": len(code_lines),
283283
"comment_lines": len(comment_lines),
284-
"blank_lines": len([l for l in lines if not l.strip()]),
284+
"blank_lines": len([line for line in lines if not line.strip()]),
285285
"is_valid": validation.is_valid,
286286
}

src/socratic_docs/extractors/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
"""
66

77
from dataclasses import dataclass, field
8-
from typing import Optional, List
8+
from typing import List, Optional
99

1010

1111
@dataclass

src/socratic_docs/extractors/registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
"""
77

88
import logging
9-
from typing import Dict, Optional, Type, List
109
from dataclasses import dataclass, field
10+
from typing import Dict, List, Optional, Type
1111

1212
from .base import BaseLanguageExtractor
1313

src/socratic_docs/multi_file_splitter.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
import logging
1313
from typing import Dict
1414

15+
from .extractors import LanguageExtractorRegistry
16+
from .project_templates import ProjectTemplateGenerator
17+
1518
logger = logging.getLogger("socrates.utils.multi_file_splitter")
1619

1720

0 commit comments

Comments
 (0)