Update

Author: ABuljko

.github/workflows/cd-linux-arm64.yaml

@@ -15,7 +15,7 @@ jobs:
   version-check:
     name: Check versioning
     runs-on: ubuntu-24.04-arm
-    container: python:3.10-slim-trixie
+    container: python:3.11-slim-trixie
     if: github.event_name == 'release'
     steps:
       - name: Checkout repository
@@ -41,7 +41,7 @@ jobs:
   build-onefile:
     name: Build onefile
     runs-on: ubuntu-24.04-arm
-    container: python:3.10-slim-trixie
+    container: python:3.11-slim-trixie
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -80,7 +80,7 @@ jobs:
   publish-binary:
     name: Publish binary
     runs-on: ubuntu-24.04-arm
-    container: python:3.10-slim-trixie
+    container: python:3.11-slim-trixie
     needs: [build-onefile, version-check]
     if: github.event_name == 'release'
     permissions:

.github/workflows/cd-linux-x64.yaml

@@ -15,7 +15,7 @@ jobs:
   version-check:
     name: Check versioning
     runs-on: ubuntu-latest
-    container: python:3.10-slim-bookworm
+    container: python:3.11-slim-bookworm
     if: github.event_name == 'release'
     steps:
       - name: Checkout repository
@@ -41,7 +41,7 @@ jobs:
   build-onefile:
     name: Build onefile
     runs-on: ubuntu-latest
-    container: python:3.10-slim-bookworm
+    container: python:3.11-slim-bookworm
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -80,7 +80,7 @@ jobs:
   publish-binary:
     name: Publish binary
     runs-on: ubuntu-latest
-    container: python:3.10-slim-bookworm
+    container: python:3.11-slim-bookworm
     needs: [build-onefile, version-check]
     if: github.event_name == 'release'
     permissions:

.github/workflows/cd-pypi.yaml

@@ -15,7 +15,7 @@ jobs:
   check-package-version:
     name: Check package version
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -30,7 +30,7 @@ jobs:
   check-tag-version:
     name: Check tag version
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     if: github.event_name == 'release'
     steps:
       - name: Checkout repository
@@ -48,7 +48,7 @@ jobs:
   build:
     name: Build
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     needs: check-package-version
     steps:
       - name: Checkout repository

.github/workflows/ci.yaml

@@ -14,7 +14,7 @@ jobs:
   pyproject-lock-file-check:
     name: Check pyproject syntax
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -25,7 +25,7 @@ jobs:
   format-code:
     name: Check code format
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -41,7 +41,7 @@ jobs:
   lint-style:
     name: Check code style
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -57,7 +57,7 @@ jobs:
   lint-typing:
     name: Check static typing
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6
@@ -84,7 +84,7 @@ jobs:
   check-version-accordance-flatpak-metadata:
     name: Check for version accordance with Flatpak metadata file
     runs-on: ubuntu-latest
-    container: python:3.10-slim
+    container: python:3.11-slim
     steps:
       - name: Checkout repository
         uses: actions/checkout@v6

nitrokeyapp/exceptions.py

@@ -196,13 +196,19 @@ def field_btn(self) -> None:
 
         loc = QLineEdit.ActionPosition.TrailingPosition
         self.action_current_password_show = self.ui.current_password.addAction(icon_visibility, loc)
-        self.action_current_password_show.triggered.connect(self.act_current_password_show)
-
         self.action_new_password_show = self.ui.new_password.addAction(icon_visibility, loc)
-        self.action_new_password_show.triggered.connect(self.act_new_password_show)
-
         self.action_repeat_password_show = self.ui.repeat_password.addAction(icon_visibility, loc)
-        self.action_repeat_password_show.triggered.connect(self.act_repeat_password_show)
+
+        for field, action in [
+            (self.ui.current_password, self.action_current_password_show),
+            (self.ui.new_password, self.action_new_password_show),
+            (self.ui.repeat_password, self.action_repeat_password_show),
+        ]:
+            action.triggered.connect(
+                lambda f=field, a=action: self._set_password_visibility(
+                    f, a, f.echoMode() == QLineEdit.EchoMode.Password
+                )
+            )
 
         self.show_current_password_check = self.ui.current_password.addAction(icon_check, loc)
         self.show_current_password_false = self.ui.current_password.addAction(icon_false, loc)
@@ -388,30 +394,11 @@ def reset_action(self) -> None:
 
     def _set_password_visibility(self, field: QLineEdit, action: QAction, show: bool) -> None:
         icon = SHOW_ICON if show else HIDE_ICON
-        mode = QLineEdit.Normal if show else QLineEdit.Password  # type: ignore [attr-defined]
+        mode = QLineEdit.EchoMode.Normal if show else QLineEdit.EchoMode.Password
         field.setEchoMode(mode)
         action.setIcon(icon)
 
-    def act_current_password_show(self) -> None:
-        show = self.ui.current_password.echoMode() == QLineEdit.Password  # type: ignore [attr-defined]
-        self._set_password_visibility(self.ui.current_password, self.action_current_password_show, show)
-
-    def act_new_password_show(self) -> None:
-        show = self.ui.new_password.echoMode() == QLineEdit.Password  # type: ignore [attr-defined]
-        self._set_password_visibility(self.ui.new_password, self.action_new_password_show, show)
-
-    def act_repeat_password_show(self) -> None:
-        show = self.ui.repeat_password.echoMode() == QLineEdit.Password  # type: ignore [attr-defined]
-        self._set_password_visibility(self.ui.repeat_password, self.action_repeat_password_show, show)
-
-    def set_current_password_show(self, show: bool = True) -> None:
-        self._set_password_visibility(self.ui.current_password, self.action_current_password_show, show)
-
-    def set_new_password_show(self, show: bool = True) -> None:
-        self._set_password_visibility(self.ui.new_password, self.action_new_password_show, show)
 
-    def set_repeat_password_show(self, show: bool = True) -> None:
-        self._set_password_visibility(self.ui.repeat_password, self.action_repeat_password_show, show)
 
     def set_device_data(
         self, path: str, uuid: str, version: str, variant: str, init_status: str

nitrokeyapp/settings_tab/__init__.py

@@ -35,7 +35,7 @@ def check_update(self) -> None:
             return
 
         current = Version.from_str(__version__)
-        latest = Version.from_str(str(release)[1:])
+        latest = Version.from_v_str(release.tag)
 
         if current < latest:
             self.ui.CheckUpdate.setText("update available")