Add passkeys tab#426
Conversation
robin-nitrokey
left a comment
There was a problem hiding this comment.
Tested with NKPK and NK3 via CTAPHID, looks good.
I cannot test CCID currently because the device is not shown at all (even on main), but I assume that it would not work because the current implementation assumes that the raw device is a CTAPHID device.
Also, it would be good to repeat the PIN prompt on a failed entry, but this is not a blocker.
|
Tested on Windows, works on administrative user accounts, but doesn't on non-administrative. |
|
disabled the passkey tab for windows without admin permissions, please re-test |
|
On the non-administrative account the Nitrokey doesn't show up at all anymore. I even tried to set |
|
@mmerklinger Does it show up with the current main? I had the same problem on Linux with this log entry: |
|
No, see #427. |
|
Tested again with |
|
The problem was that the pcsc extra was not active in my installation. This should trigger a message in nitrokey-app2 if |
| # repurpose the username/password/comment fields for FIDO2 details (read-only) | ||
| self.ui.username_label.setText("User:") | ||
| self.ui.username.setReadOnly(True) | ||
| self.ui.password_label.setText("E-Mail:") |
There was a problem hiding this comment.
E-Mail is a misleading label as it is up to the relying party how the field is used.
secrets_tab.uifor that, not optimal