Skip to content

Add passkeys tab#426

Merged
daringer merged 2 commits into
mainfrom
passkeys-tab
Apr 30, 2026
Merged

Add passkeys tab#426
daringer merged 2 commits into
mainfrom
passkeys-tab

Conversation

@daringer
Copy link
Copy Markdown
Collaborator

  • show passkeys in a tab
  • repurpose the secrets_tab.ui for that, not optimal
  • show display_name, e-mail and ID in right detail view
  • allow deletion
  • pin handling is not optimal, we have to centralize this, but ok for now

Copy link
Copy Markdown
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with NKPK and NK3 via CTAPHID, looks good.

I cannot test CCID currently because the device is not shown at all (even on main), but I assume that it would not work because the current implementation assumes that the raw device is a CTAPHID device.

Also, it would be good to repeat the PIN prompt on a failed entry, but this is not a blocker.

@mmerklinger
Copy link
Copy Markdown
Member

Tested on Windows, works on administrative user accounts, but doesn't on non-administrative.

@daringer
Copy link
Copy Markdown
Collaborator Author

disabled the passkey tab for windows without admin permissions, please re-test

@mmerklinger
Copy link
Copy Markdown
Member

On the non-administrative account the Nitrokey doesn't show up at all anymore. I even tried to set NITROKEY_FORCE_CCID.

@robin-nitrokey
Copy link
Copy Markdown
Member

@mmerklinger Does it show up with the current main? I had the same problem on Linux with this log entry:

INFO nitrokeyapp.gui failed adding device

@mmerklinger
Copy link
Copy Markdown
Member

No, see #427.

@robin-nitrokey
Copy link
Copy Markdown
Member

Tested again with NITROKEY_FORCE_CCID=1 on another machine and it works as expected. I’ll try to figure out what caused the problem on the original machine.

@robin-nitrokey
Copy link
Copy Markdown
Member

The problem was that the pcsc extra was not active in my installation. This should trigger a message in nitrokey-app2 if NITROKEY_FORCE_CCID is set and also in nitrokey-sdk-py if use_ccid is set to true.

# repurpose the username/password/comment fields for FIDO2 details (read-only)
self.ui.username_label.setText("User:")
self.ui.username.setReadOnly(True)
self.ui.password_label.setText("E-Mail:")
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E-Mail is a misleading label as it is up to the relying party how the field is used.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

created #430 for this

@daringer daringer merged commit d37d041 into main Apr 30, 2026
34 of 35 checks passed
@daringer daringer deleted the passkeys-tab branch April 30, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants