Design layout change#439
Conversation
|
Hi @robin-nitrokey |
|
It looks like this is my commit from the main branch: 6abc3c0 Did you maybe accidentally run Regarding the dark mode, I think this was actually an intended change in #297. But indeed it does not look good with the default icons. Maybe we should have a different icon set for dark mode? |
|
No, I did not run any command like that, but yeah I will drop it Good to know, then I will also fix up the dark mode as well, and change up the SVGs that we have and separate them in their respective folders |
ABuljko
force-pushed
the
design-layout-change
branch
from
e53d3db to
babaf0d
Compare
|
Added the dark mode properly now |
|
Thanks! Looking at the screenshot I noticed two things:
|
|
Thank you! |
|
I noticed that you also included some functional changes/fixes. Can you please move them to separate commits with some context to make them easier to review (or maybe a separate PR)? |
|
Sorry, I forgot to mention them |
ABuljko
force-pushed
the
design-layout-change
branch
from
9aa42ee to
ae06152
Compare
- Redesign main layout, sidebar, and card styles across all tabs - Add dark stylesheet that auto-switches with the OS color scheme - Wire up colorSchemeChanged signal for live light/dark switching - Add QTimer.singleShot(0) to fix Qt startup theme-detection race - Introduce light_mode/ and dark_mode/ icon folders; themed icon resolver in QtUtilsMixIn picks the correct variant per scheme - Add refresh_icons() to all tabs so icons update on theme switch - Fix Passkeys tab (Fido2Tab) missing from icon refresh chain - Change device tile hover/checked state to reddish accent
- Warn the user when ≤2 PIN retries remain before the Passwords app locks the device permanently - Require PIN confirmation when setting a new Passwords PIN to catch typos before they take effect - Show a friendlier 'Incorrect PIN. Please try again.' error instead of the raw SDK exception string - Style status bar error text red and bold; clear the style on dismiss - Remove a hardcoded grey stylesheet from the progress bar
ABuljko
force-pushed
the
design-layout-change
branch
from
ae06152 to
9817609
Compare
|
@robin-nitrokey |
mmerklinger
requested review from
a team,
daringer,
james-knippes,
mmerklinger,
robin-nitrokey and
sosthene-nitrokey
and removed request for
a team
|
|
||
| @Slot(object) | ||
| def credential_deleted(self, credential: Optional[Fido2Credential]) -> None: | ||
| def credential_deleted(self, credential: object) -> None: |
There was a problem hiding this comment.
There are some more changes like this. Can’t we change the slot type to match the type annotation?
There was a problem hiding this comment.
The reviewer is right, @slot(object) and Optional[Fido2Credential] can coexist 😲
Changing it to an object was unnecessary and made the type safety weaker 😅😅😅
Restored the original annotations. Added # type: ignore [arg-type] due to a PySide6-stubs limitation
Alternative options would take more effort, U can decide if I should go through with them or drop the last commit
Use type: ignore [arg-type] to satisfy PySide6-stubs while keeping the more specific Optional[Fido2Credential] and Type[BaseException] annotations instead of the weaker object fallback.
2 participants
Uh oh!
There was an error while loading. Please reload this page.