Skip to content

Password generating button#441

Open
ABuljko wants to merge 3 commits into
Nitrokey:mainfrom
ABuljko:generate-random-password
Open

Password generating button#441
ABuljko wants to merge 3 commits into
Nitrokey:mainfrom
ABuljko:generate-random-password

Conversation

@ABuljko

@ABuljko ABuljko commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Issue ticket #301

  • Generates randomised passwords

@mmerklinger mmerklinger requested review from a team, daringer, james-knippes, mmerklinger, robin-nitrokey and sosthene-nitrokey and removed request for a team June 22, 2026 10:43

@robin-nitrokey robin-nitrokey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a nice feature to make the length and alphabet configurable. Unfortunately there are still some sites with arbitrary limitations. Maybe with a set of checkboxes per group of characters so that it is easy to select and deselect letters, numbers, punctuation and other symbols? And possibly an input field to add custom characters. What do you think?

@ABuljko

ABuljko commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Checkboxes per group- I think that this would be a good idea
Custom characters field- The user can just edit the generated password themselves in the field
Length- as for the length I think that it is fine, but in case websites have a cap on the number of characters a password could have is the only use case I see for this (This is just my opinion though, I am open to feedback)

To integrate this into the UI though it might be tricky, especially with the check-boxes. The only way I see it happening would be through a pop-up box appearing when pressing the generate button

@ABuljko ABuljko requested a review from robin-nitrokey June 22, 2026 21:53
@robin-nitrokey

Copy link
Copy Markdown
Member

Custom characters field- The user can just edit the generated password themselves in the field

Okay.

Length- as for the length I think that it is fine, but in case websites have a cap on the number of characters a password could have is the only use case I see for this (This is just my opinion though, I am open to feedback)

Yes, one use case are sites with a length cap. Also it’s just a personal preference. For example I normally use 32 character passwords because why not?

To integrate this into the UI though it might be tricky, especially with the check-boxes. The only way I see it happening would be through a pop-up box appearing when pressing the generate button

Nitrokey App 2 is mostly trying to avoid popups and message boxes in favor of a more responsive design. To stay consistent with that, we could maybe insert the relevant widgets below the password box when clicking the "Generate" button. That being said, I’m not fully convinced by this responsive approach and still prefer more classical user interfaces, so a popup is also fine for me. :)

@ABuljko

ABuljko commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Yes, one use case are sites with a length cap. Also it’s just a personal preference. For example I normally use 32 character passwords because why not?

Haha oki then lets do it

Nitrokey App 2 is mostly trying to avoid popups and message boxes in favor of a more responsive design. To stay consistent with that, we could maybe insert the relevant widgets below the password box when clicking the "Generate" button. That being said, I’m not fully convinced by this responsive approach and still prefer more classical user interfaces, so a popup is also fine for me. :)

Oki then I will try the NK preferred option first IG, but I also personally think that it will look best as a pop-up since it might make the page too cluttery :)

@ABuljko ABuljko requested a review from a team as a code owner June 22, 2026 23:37
@ABuljko

ABuljko commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

PLS check the style I used 🍀🍀🍀

  • Password length set from 1 to 64
  • Added three checkboxes (number, letter, and symbol)
  • If all three checkboxes are disabled and the user tries to generate a password they will receive a warning message

@robin-nitrokey robin-nitrokey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have two suggestions:

  • I think moving the password generation widgets to the second column (so that they align with the line edit) would make the UI clearer.
  • Generating the password is cheap so we could always update the generated password when the user changes one of the four generation settings.

What do you think?

@ABuljko

ABuljko commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

I like it 🍀
Will do it now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants