Clear clipboard after certain time#442
Merged
robin-nitrokey merged 1 commit intoJun 25, 2026
Merged
Conversation
mmerklinger
requested review from
a team,
daringer,
james-knippes,
mmerklinger,
robin-nitrokey and
sosthene-nitrokey
and removed request for
a team
robin-nitrokey
left a comment
robin-nitrokey
left a comment
Member
There was a problem hiding this comment.
LGTM, just two minor questions.
robin-nitrokey
force-pushed
the
clipboard-clear-after-certain-time
branch
from
c6ce568 to
ef87c3e
Compare
robin-nitrokey
force-pushed
the
clipboard-clear-after-certain-time
branch
from
ef87c3e to
bd71627
Compare
Member
|
Squashed and merged, thanks! I noticed that there is a race condition where copying the value multiple times does not increase the timeout, so e. g. if you copy a second time nine seconds after the first copy, the value will only be valid for one second. It is not a big issue so I’ve merged anyway. If you want to, you can fix it in a separate PR. It should be possible to fix it by using one timer per field and restarting the timer once a value is copied. |
Contributor
Author
|
I will keep it noted down, and later down the line in one of my PRs i will incorporate the fix :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue ticket #248