Skip to content

PIV support added#445

Open
ABuljko wants to merge 4 commits into
Nitrokey:mainfrom
ABuljko:piv-support
Open

PIV support added#445
ABuljko wants to merge 4 commits into
Nitrokey:mainfrom
ABuljko:piv-support

Conversation

@ABuljko

@ABuljko ABuljko commented Jun 26, 2026

Copy link
Copy Markdown
Contributor
  • 4 PIV slots with certificate details
  • Generate key (ECC P-256/P-384, RSA 2048) with automatic self-signed certificate
  • Import the existing key and certificate from the P12 file
  • Change PIN and PUK
  • Factory reset PIV application
  • Refresh slot state on demand
  • Fallback if PySCard is missing or the device is not in CCID mode

Solution for #376

@ABuljko ABuljko requested a review from a team as a code owner June 26, 2026 07:50
@ABuljko ABuljko requested review from daringer, james-knippes, mmerklinger, robin-nitrokey and sosthene-nitrokey and removed request for a team June 26, 2026 07:50
@daringer

daringer commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

on a first glance this looks pretty good - but most of the low-level functionality does not belong directly into nitrokey-app2 - we should introduce it into nitrokey-sdk-py. Especially as there is also piv functionality implemented in pynitrokey, thus please first let's do a proper analysis first. Roughly like this:

  1. name and identify pynitrokey piv functionalities (pynitrokey issue)
  2. name expected nitrokey-app2 functionalities (app2 issue)
  3. decide which overlapping functionalities should go into nitrokey-sdk-py (sdk issue)
  4. iterate on this and then once confirmed implement bottom top (first sdk, then inside the frontend(s))

@ABuljko

ABuljko commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@daringer then should we keep this PR as a working prototype while the SDK work happens in parallel, then swap out data.py when the SDK has the APIs
What do you think 🤔 ❓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants