PIV support added#445
Open
ABuljko wants to merge 4 commits into
Open
Conversation
Collaborator
|
on a first glance this looks pretty good - but most of the low-level functionality does not belong directly into nitrokey-app2 - we should introduce it into nitrokey-sdk-py. Especially as there is also piv functionality implemented in pynitrokey, thus please first let's do a proper analysis first. Roughly like this:
|
Contributor
Author
|
@daringer then should we keep this PR as a working prototype while the SDK work happens in parallel, then swap out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution for #376