Syntax review#446
Conversation
ABuljko
requested review from
daringer,
james-knippes,
mmerklinger,
robin-nitrokey and
sosthene-nitrokey
and removed request for
a team
|
@robin-nitrokey should I ignore the errors for now since they are appearing because the GitHub Actions environment doesn't have Python 3.11+ installed 🤔 👀 Should I put it back to 3.10? |
robin-nitrokey
left a comment
robin-nitrokey
left a comment
There was a problem hiding this comment.
should I ignore the errors for now since they are appearing because the GitHub Actions environment doesn't have Python 3.11+ installed 🤔 👀
You can update the container used in the CI from python:3.10-slim to python:3.11-slim.
|
Thanks for the fixes! Please rebase onto main and squash the changes into one commit with a descriptive commit message. |
|
How do I fix this BTW |
|
You can fix it by rebasing your PR branch on the latest main. |
|
Updated the description |
|
Thanks. Please squash the changes into one commit and update its description. |
Done ❤️ 🍀 |
- Modernize type hints: `X | None`, `list[X]`, `collections.abc` imports across 28 files - Remove unused code: dead assignments, duplicate methods, legacy files (`exceptions.py`, `windows_notification.py`) - Apply reviewer suggestions: Qt6 enums, `_set_password_visibility` helper, `Version.from_v_str` - Bump `pyproject.toml` to `requires-python = ">=3.11"`, regenerate `poetry.lock` - Update CI/CD workflows to Python 3.11 (Linux containers + macOS brew with `--overwrite`) - Fix code style: `ruff format` + `ruff check --fix`
robin-nitrokey
force-pushed
the
syntax-review
branch
from
5d4eaab to
2798e25
Compare
|
Thanks, merged. |
2 participants
X | None,list[X],collections.abcimports)exceptions.py,windows_notification.py)_set_password_visibilityhelper,Version.from_v_str)pyproject.tomlandpoetry.lockupdated to require Python>=3.11ruff format+ruff check --fix)