Skip to content

Fix for wrong channel#448

Open
AdityaMitra5102 wants to merge 8 commits into
Nitrokey:mainfrom
AdityaMitra5102:issue-444
Open

Fix for wrong channel#448
AdityaMitra5102 wants to merge 8 commits into
Nitrokey:mainfrom
AdityaMitra5102:issue-444

Conversation

@AdityaMitra5102

Copy link
Copy Markdown

Changes:

  • Disable lazy loading for already initialized devices. Fixes the reproducer
  • Filter by VID added. We dont need the DeviceManager.add() functions to run if non Nitrokey devices are connected to the PC
  • Check for duplicate devices, fixes windows reports Nk3 as three different devices, forcing it into a retry loop

Handles #444

@AdityaMitra5102 AdityaMitra5102 requested a review from a team as a code owner June 30, 2026 08:50
@AdityaMitra5102 AdityaMitra5102 requested review from daringer, james-knippes, mmerklinger, robin-nitrokey and sosthene-nitrokey and removed request for a team June 30, 2026 08:50
Comment thread nitrokeyapp/gui.py Outdated
@robin-nitrokey

Copy link
Copy Markdown
Member

Thanks. Looks like it fixed the problem for me on Linux too. Still needs to be tested for macOS and probably changed to take into account Eric-Canas/USBMonitor#10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants