Skip to content

Commit 9dc26a2

Browse files
committed
tests cleanup
1 parent b329090 commit 9dc26a2

2 files changed

Lines changed: 6 additions & 10 deletions

File tree

document_page_reference/models/document_page.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def _get_document(self, code):
5050

5151
def get_content(self):
5252
self.ensure_one()
53-
raw = self.content or ""
53+
raw = str(self.content or "")
5454
content_parsed = Markup(raw)
5555
for text in re.findall(r"\{\{.*?\}\}", raw):
5656
reference = re.sub(r"<[^>]*>", "", text).replace("{{", "").replace("}}", "")
@@ -65,7 +65,7 @@ def get_content(self):
6565
full_link = match.group(0)
6666
reference = match.group(1)
6767
content_parsed = content_parsed.replace(
68-
full_link, self._resolve_reference(reference)
68+
Markup(full_link), self._resolve_reference(reference)
6969
)
7070
return content_parsed
7171

@@ -91,7 +91,7 @@ def _resolve_reference(self, code):
9191
)
9292

9393
def get_raw_content(self):
94-
return Markup(self.with_context(raw_reference=True).get_content())
94+
return str(self.with_context(raw_reference=True).get_content())
9595

9696
@api.model_create_multi
9797
def create(self, vals_list):

document_page_reference/tests/test_document_reference.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ def test_no_constrains(self):
3737
self.assertFalse(self.page2.reference)
3838

3939
def test_check_raw(self):
40-
self.assertEqual(self.page2.display_name, self.page1.get_raw_content())
40+
self.assertEqual(
41+
str(self.page2.display_name), str(self.page1.get_raw_content())
42+
)
4143

4244
def test_auto_reference(self):
4345
"""Test if reference is proposed when saving a page without one."""
@@ -77,12 +79,6 @@ def test_compute_content_parsed(self):
7779
self.assertIn(f"href='{self.page2.backend_url}'", self.page1.content_parsed)
7880
self.assertIn("Test Page 2", self.page1.content_parsed)
7981

80-
def test_compute_content_parsed_rich_text(self):
81-
# Case where editor injects tags inside the curly braces
82-
self.page1.content = Markup("<p>{{<b>r2</b>}}</p>")
83-
self.page1._compute_content_parsed()
84-
self.assertIn(f"data-oe-id='{self.page2.id}'", self.page1.content_parsed)
85-
8682
def test_inverse_content_replacement(self):
8783
self.page1.write({"content": "{{r2}}"})
8884
self.assertIn(f"data-oe-id='{self.page2.id}'", self.page1.content)

0 commit comments

Comments
 (0)