Simplify embedded-hal v1.0 error handling types#31
Open
wackazong wants to merge 3 commits intoNitrokey:mainfrom
Open
Simplify embedded-hal v1.0 error handling types#31wackazong wants to merge 3 commits intoNitrokey:mainfrom
wackazong wants to merge 3 commits intoNitrokey:mainfrom
Conversation
Collaborator
Do you have an example of such an issue? This PR would be a breaking change and would make the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embedded-hal v1.0 was also relying on the dedicated error type introduced to be able to handle NACKs. I removed it because it is not needed and causes unnecessary issues with trait boundaries.