skip bombed regions when uploading new version of website (#382)

Author: arianvp

.github/workflows/upload-legacy-ami.yml

@@ -126,7 +126,11 @@ jobs:
           role-to-assume: arn:aws:iam::${{ vars.AWS_ACCOUNT_ID }}:role/github-pages
           aws-region: ${{ vars.AWS_REGION }}
       - name: Describe images
-        run: nix run .#describe-images > ./site/images.json
+        run: |
+          nix run .#describe-images -- \
+            --best-effort-region me-central-1 \
+            --best-effort-region me-south-1 \
+            > ./site/images.json
       - name: Upload pages
         uses: actions/upload-pages-artifact@7b1f4a764d45c48632c6b24a0339c27f5614fb0b # v4.0.0
         with:

upload-ami/src/upload_ami/describe_images.py

@@ -1,3 +1,4 @@
+import argparse
 import logging
 import boto3
 import json
@@ -6,6 +7,15 @@
 
 
 def main() -> None:
+    parser = argparse.ArgumentParser()
+    parser.add_argument(
+        "--best-effort-region",
+        help="Regions where failures are logged as warnings instead of errors",
+        action="append",
+        default=[],
+    )
+    args = parser.parse_args()
+
     logging.basicConfig(level=logging.INFO)
     ec2: EC2Client = boto3.client("ec2")
     regions = ec2.describe_regions()["Regions"]
@@ -14,13 +24,22 @@ def main() -> None:
 
     for region in regions:
         assert "RegionName" in region
-        ec2r = boto3.client("ec2", region_name=region["RegionName"])
-
-        result = ec2r.describe_images(
-            Owners=["self"],
-            ExecutableUsers=["all"],
-        )
-        images[region["RegionName"]] = result
+        region_name = region["RegionName"]
+        ec2r = boto3.client("ec2", region_name=region_name)
+
+        try:
+            result = ec2r.describe_images(
+                Owners=["self"],
+                ExecutableUsers=["all"],
+            )
+        except Exception as e:
+            if region_name not in args.best_effort_region:
+                raise
+            logging.warning(
+                f"Describing images in {region_name} failed (best-effort, ignoring): {e}"
+            )
+            continue
+        images[region_name] = result
 
     print(json.dumps(images, indent=2))