Skip to content

Commit a8fd87f

Browse files
committed
FromCabal: remove LLVM evil
1 parent e9e2ebd commit a8fd87f

3 files changed

Lines changed: 2 additions & 3 deletions

File tree

cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal.hs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,6 @@ fromPackageDescription haskellResolver nixpkgsResolver missingDeps flags Package
172172

173173
resolveInNixpkgs :: Identifier -> Binding
174174
resolveInNixpkgs i
175-
| i `elem` ["clang","lldb","llvm"] = binding # (i, path # ["self","llvmPackages",i]) -- TODO: evil!
176175
| i == "gtk2" = binding # (i, path # ["pkgs","gtk2"]) -- TODO: these cases should not be necessary
177176
| i == "gtk3" = binding # (i, path # ["pkgs","gtk3"])
178177
| i == "gtksourceview3" = binding # (i, path # ["pkgs","gtksourceview3"])

cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/PostProcess.hs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ hooks =
112112
, ("git-annex >= 6.20170925 && < 6.20171214", set doCheck False) -- some versions of git-annex require their test suite to be run inside of a git checkout
113113
, ("github-backup", set (executableDepends . tool . contains (pkg "git")) True)
114114
, ("GLFW", over (libraryDepends . system) (Set.union (Set.fromList [bind "pkgs.xorg.libXext", bind "pkgs.xorg.libXfixes"])))
115-
, ("GlomeVec", set (libraryDepends . pkgconfig . contains (bind "self.llvmPackages.llvm")) True)
115+
, ("GlomeVec", set (libraryDepends . pkgconfig . contains (bind "pkgs.llvmPackages.llvm")) True)
116116
, ("graphviz", set (testDepends . system . contains (pkg "graphviz")) True)
117117
, ("gtk3", gtk3Hook)
118118
, ("gtkglext", gtkglextHook)

doc/frequently-asked-questions.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -488,7 +488,7 @@ The solution is to add it as another package to the environment:
488488
489489
.. code:: shell
490490
491-
$ nix-shell -p '(haskellPackages.ghcWithPackages.override { useLLVM = true; }) (ps: with ps; [mtl])' 'haskellPackages.llvmPackages.llvm'
491+
$ nix-shell -p '(haskellPackages.ghcWithPackages.override { useLLVM = true; }) (ps: with ps; [mtl])' 'haskellPackages.ghc.llvmPackages.llvm'
492492
493493
[nix-shell:~]$ llvm-ar --help
494494
OVERVIEW: LLVM Archiver

0 commit comments

Comments
 (0)