queue-runner: introduce finished/unfinished per machine type metrics#1817
Open
MiniHarinn wants to merge 1 commit into
Open
queue-runner: introduce finished/unfinished per machine type metrics#1817MiniHarinn wants to merge 1 commit into
MiniHarinn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added finished/unfinished step metrics to per machine type (
hydraqueuerunner_machine_type_*) metric family. I choose to put it under this family instead of makingsteps_*family a per machine metrics(as per issue's request). This is because I quickly realized that this is the intended place to put per machine type metrics.Related(?): #1816
Notes
This is also my first PR to hydra and it happened to touch our new queue runner, so please tell me if i did something wrong :p