feat: add pagination for GET notification and fix tests accordingly

Author: devnchill

src/api/notifications/views.py

@@ -26,6 +26,7 @@ class NotificationPagination(PageNumberPagination):
 class NotificationViewSet(viewsets.ReadOnlyModelViewSet):
     permission_classes = [IsAuthenticated]
     serializer_class = NotificationSerializer
+    pagination_class = NotificationPagination
 
     def get_queryset(  # pyright: ignore[reportIncompatibleMethodOverride]
         self,

src/api/tests/test_notifications.py

@@ -18,13 +18,29 @@ def test_list_notifications_authenticated(
     response = client.get(url)
 
     assert response.status_code == 200
-    assert len(response.data) == 1
-    assert response.data[0]["title"] == (
+    assert response.data["count"] == 1
+
+    api_data = response.data["results"]
+    assert api_data[0]["title"] == (
         "CVE-2025-0001 was automatically matched to packages you subscribed to"
     )
-    assert response.data[0]["is_read"] is False
-    assert "id" in response.data[0]
-    assert "created_at" in response.data[0]
+    assert api_data[0]["is_read"] is False
+    assert "id" in api_data[0]
+    assert "created_at" in api_data[0]
+
+
+def test_list_notifications_are_paginated(
+    user: User,
+    client: APIClient,
+    make_maintainer_notification: Callable[..., list[Notification]],
+):
+    make_maintainer_notification(user)
+    url = reverse("notification-list")
+
+    response = client.get(url)
+    assert "previous" in response.data
+    assert "next" in response.data
+    assert "count" in response.data
 
 
 def test_list_notifications_excludes_other_users_notifications(
@@ -38,7 +54,7 @@ def test_list_notifications_excludes_other_users_notifications(
     response = client.get(url)
 
     assert response.status_code == 200
-    assert len(response.data) == 0
+    assert response.data["count"] == 0
 
 
 def test_list_notifications_unauthenticated(
@@ -61,7 +77,7 @@ def test_list_notifications_empty(
     response = client.get(url)
 
     assert response.status_code == 200
-    assert len(response.data) == 0
+    assert response.data["count"] == 0
 
 
 def test_list_notifications_includes_text_notifications(
@@ -74,9 +90,11 @@ def test_list_notifications_includes_text_notifications(
     response = client.get(url)
 
     assert response.status_code == 200
-    assert len(response.data) == 1
-    assert response.data[0]["title"] == "Hello"
-    assert response.data[0]["is_read"] is False
+    assert response.data["count"] == 1
+
+    api_data = response.data["results"]
+    assert api_data[0]["title"] == "Hello"
+    assert api_data[0]["is_read"] is False
 
 
 def test_list_notifications_shows_both_types(
@@ -91,4 +109,4 @@ def test_list_notifications_shows_both_types(
     response = client.get(url)
 
     assert response.status_code == 200
-    assert len(response.data) == 2
+    assert response.data["count"] == 2