feat: integrate django-prometheus for web serivce metrics by devnchill · Pull Request #1085 · NixOS/nix-security-tracker

devnchill · 2026-06-07T08:08:13Z

devnchill · 2026-06-07T08:12:41Z

hello @fricklerhandwerk , I wanted to clear this point that I have to connect grafana just for us to see how metrics would show up in grafana right ? I don't have to modify infra side for this , just the project side and then use nix to create test vm where grafana would be setup and visualize the metrics coming from the project ?

Erethon · 2026-06-16T20:48:35Z

hello @fricklerhandwerk , I wanted to clear this point that I have to connect grafana just for us to see how metrics would show up in grafana right ? I don't have to modify infra side for this , just the project side and then use nix to create test vm where grafana would be setup and visualize the metrics coming from the project ?

Hello! Technically you only need to setup Prometheus in a test VM to collect the metrics, no Grafana is needed. If you want to test the changes you made, I think adding a VM test or python test to check that the metrics endpoint (/metrics) returns one of the default django-prometheus metrics is more than enough. Spinning up Prometheus and Grafana for a test would be overkill in my opinion, but maybe something that some people would like to have in a dev environment.

fricklerhandwerk · 2026-06-17T07:22:27Z

Yeah, having a way to at least manually check out of band what a given change is like would be good. I thought about maybe just adding instances to our clumsy NixOS dev module. It's dumb but it gets you the thing quickly.

But for this change, a check in the smoke test should be enough.

devnchill · 2026-06-17T10:19:08Z

got it

devnchill · 2026-06-18T06:32:50Z

ig i'll wait for #1131 to merge ? would help me in testing 😆

fricklerhandwerk · 2026-06-18T08:41:26Z

In the meantime or later on I'd strongly recommend going through the contributing guide and exercising the workflows to obtain data locally. Such as "fetch some channels and run an evaluation". Because without data you don't have anything to look at in the dashboards.

Likely there are some papercuts there, such as for how to get a reasonable number of CVEs for testing. It would be such a great contribution if you extracted one such workflow as a separate guide like @DarshanCode2005 did in #1072. Right now these bits and pieces are scattered.

devnchill · 2026-06-18T09:22:28Z

Makes sense, I'll work on that in the meantime 😆

devnchill · 2026-06-25T07:08:06Z

hello @fricklerhandwerk , I first saved the new dashboard as copy so due to that the version i believe started counter from 0 , i noticed the prev dashboard had 33 , so I am not sure if i have to replace current version 4 with prev one , same goes for uid, it changes on each save i am assuming . i wasn't sure if changing id brings any breaking changes . if it does ig , we'll have to reuse old one ?

Oh also from prev discussion it seemed that there were 2 ways to add test for this, one was through pytest and another was through nix test , atm I picked django , do I need to add test for nix vm too ?

apart from that this pr had so much of learning experience lol , learned several new stuff because of this 😄 .

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

fricklerhandwerk · 2026-06-25T12:44:48Z

Since we're exposing directly from Django, the unit test is perfectly fine. I still need to get the Grafana dev setup working again (not sure what got messed up before I merged it, but it worked and now doesn't) to try it out.

Not sure the stray changes to the dashboard JSON are all needed though. @Erethon opinions?

devnchill · 2026-06-25T12:50:36Z

Hmm weird, Grafana dev setup was working for me couple hrs ago though, will try it again when I go home.

Regarding the dashboard, I thought you mentioned in initial issue that it would be nice to connect it to Grafana for quick lookup locally .. So I thought this is what you meant from that ... Mb for misunderstanding 😅

I'll remove dashboard changes when I reach home

fricklerhandwerk · 2026-06-25T13:22:53Z

Oh the dashboard changes adding the data are fine, I mean all the unrelated stuff such as reformatting.

devnchill · 2026-06-25T13:35:22Z

Oh my nvim is configured to format on save so I believe it used prettier for that when I saved the file

Erethon · 2026-07-03T09:58:57Z

Not sure the stray changes to the dashboard JSON are all needed though. @Erethon opinions?

The plugin_version changes look fine to me, I guess they're coming from a newer Grafana version. The nvim auto-formatting will be reverted in a future export, so I suggest @devnchill you re-export the dashboard without the auto-formatting.

Erethon

I've left two inline comments about the changes to the Grafana dashboard. If we don't care to have everything in the same page, we could re-use the dashboard from this PR (I have no idea why it wasn't merged :().

Erethon · 2026-07-03T10:02:37Z

            "uid": "${DS_PROMETHEUS}"
+          },
+          "editorMode": "builder",
+          "expr": "django_http_requests_latency_seconds_by_view_method_count",


Please add a filter to distinguish between the staging/production instance or any other instances of django_http_requests_latency_seconds_by_view_method_count

hello @Erethon , I have a doubt ,
"expr": "django_http_requests_latency_seconds_by_view_method_count{instance=\"$Instance\"}",if i use this, then it would show empty results no? because label is instance scraping the sql_delta metric and since sql and django run on different port, label would end up becoming different for both sql and django no? any advice ?

Erethon · 2026-07-03T10:03:04Z

+            "uid": "${DS_PROMETHEUS}"
+          },
+          "editorMode": "builder",
+          "expr": "django_http_responses_total_by_status_total",


Please add a filter to distinguish between the staging/production instance or any other instances of django_http_responses_total_by_status_total.

github-project-automation Bot added this to Nixpkgs Vulnerability Tracker Jun 7, 2026

devnchill force-pushed the web-metrics branch from 388a911 to 9967958 Compare June 16, 2026 12:13

fricklerhandwerk mentioned this pull request Jun 17, 2026

feat: Grafana dashboard for local development #1131

Merged

devnchill mentioned this pull request Jun 20, 2026

docs: extract data ingestion and matching into a separate guide #1137

Merged

devnchill force-pushed the web-metrics branch 2 times, most recently from 0872a06 to ebcdb88 Compare June 24, 2026 12:46

devnchill added 3 commits June 25, 2026 12:33

feat: integrate django-prometheus for web serivce metrics

19c9ca1

feat: add django-metrics as source for prometheus

40b646e

test: django-prometheus metrics endpoint

0434324

devnchill force-pushed the web-metrics branch from 9f9597b to b980e2e Compare June 25, 2026 07:03

devnchill marked this pull request as ready for review June 25, 2026 07:04

fricklerhandwerk approved these changes Jun 25, 2026

View reviewed changes

fricklerhandwerk requested a review from Copilot June 25, 2026 08:14

Copilot AI reviewed Jun 25, 2026

fricklerhandwerk requested review from Erethon and Copilot June 25, 2026 08:14

Copilot AI reviewed Jun 25, 2026

Erethon requested changes Jul 3, 2026

View reviewed changes

devnchill force-pushed the web-metrics branch from b980e2e to 953b8d0 Compare July 3, 2026 16:08

devnchill marked this pull request as draft July 3, 2026 16:08

feat: add panels in grafana to view django metrics

cce3d53

devnchill force-pushed the web-metrics branch from 953b8d0 to cce3d53 Compare July 3, 2026 16:11

devnchill marked this pull request as ready for review July 12, 2026 02:01

Uh oh!

Conversation

devnchill commented Jun 7, 2026

Uh oh!

devnchill commented Jun 7, 2026

Uh oh!

Erethon commented Jun 16, 2026

Uh oh!

fricklerhandwerk commented Jun 17, 2026

Uh oh!

devnchill commented Jun 17, 2026

Uh oh!

devnchill commented Jun 18, 2026

Uh oh!

fricklerhandwerk commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devnchill commented Jun 18, 2026

Uh oh!

devnchill commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

fricklerhandwerk commented Jun 25, 2026

Uh oh!

devnchill commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fricklerhandwerk commented Jun 25, 2026

Uh oh!

devnchill commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Erethon commented Jul 3, 2026

Uh oh!

Erethon left a comment

Choose a reason for hiding this comment

Uh oh!

Erethon Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

devnchill Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

devnchill Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Erethon Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fricklerhandwerk commented Jun 18, 2026 •

edited

Loading

devnchill commented Jun 25, 2026 •

edited

Loading

devnchill commented Jun 25, 2026 •

edited

Loading

devnchill commented Jun 25, 2026 •

edited

Loading