docs: extract data ingestion and matching into a separate guide#1137
Conversation
fricklerhandwerk
left a comment
There was a problem hiding this comment.
Very good! Don't forget to remove the now-redundant bits from the other file.
5cc93cc to
cd2b33e
Compare
|
I was wondering if I should include resetting db in this or not, any thoughts 😅 ? |
|
No, it's a different workflow and only relevant for people with access to staging anyway. Also it's so short, it can be part of a little collection of related things. |
fricklerhandwerk
left a comment
There was a problem hiding this comment.
Good stuff. I'll squash and merge it soon.
|
btw I had one silly question , once my pr is ready for review , should i squash them beforehand or let it have separate commits and you squash them 😅 ? |
|
If you squash them I can just press the button, that makes it faster of course! But sometimes it's hard to know when one is really really done and then it degrades to a series of force pushes, at which point it becomes fiddly for me to figure out what even changed. So generally yes do it, but with a bit of care as to whether it's already time. |
|
understood :) |
9194e4f to
0fbe877
Compare
|
I rebased and squashed it |
0fbe877 to
68c9ef2
Compare
Continuing #1085 (comment)
Plan is to create a isolated and more beginner friendly guide to show how to ingest and match data locally .
What i plan to do further is show example of
ingest bulk ...command, and want some thoughts on if it would be good to remove the relevant part fromcontributing.mdand let this doc be sufficient or not.apart from that , there's resetting db table which i am assuming is only for those who have ssh access so it would be nice to add another section for devs who don't have the access ...