Skip to content

docs: extract data ingestion and matching into a separate guide#1137

Merged
fricklerhandwerk merged 1 commit into
NixOS:mainfrom
devnchill:docs/data-ingestion-and-matching
Jun 23, 2026
Merged

docs: extract data ingestion and matching into a separate guide#1137
fricklerhandwerk merged 1 commit into
NixOS:mainfrom
devnchill:docs/data-ingestion-and-matching

Conversation

@devnchill

Copy link
Copy Markdown
Member

Continuing #1085 (comment)

Plan is to create a isolated and more beginner friendly guide to show how to ingest and match data locally .

What i plan to do further is show example of ingest bulk ... command, and want some thoughts on if it would be good to remove the relevant part from contributing.md and let this doc be sufficient or not.

apart from that , there's resetting db table which i am assuming is only for those who have ssh access so it would be nice to add another section for devs who don't have the access ...

@fricklerhandwerk fricklerhandwerk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! Don't forget to remove the now-redundant bits from the other file.

Comment thread docs/data_ingestion_and_matching.md Outdated
Comment thread docs/data_ingestion_and_matching.md Outdated
Comment thread docs/data_ingestion_and_matching.md Outdated
Comment thread docs/data_ingestion_and_matching.md Outdated
@devnchill devnchill force-pushed the docs/data-ingestion-and-matching branch from 5cc93cc to cd2b33e Compare June 20, 2026 16:59
@devnchill

Copy link
Copy Markdown
Member Author

I was wondering if I should include resetting db in this or not, any thoughts 😅 ?

@fricklerhandwerk

Copy link
Copy Markdown
Collaborator

No, it's a different workflow and only relevant for people with access to staging anyway. Also it's so short, it can be part of a little collection of related things.

Comment thread CONTRIBUTING.md Outdated
@devnchill devnchill marked this pull request as ready for review June 21, 2026 11:57

@fricklerhandwerk fricklerhandwerk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. I'll squash and merge it soon.

Comment thread CONTRIBUTING.md Outdated
Comment thread docs/quickstart.md Outdated
@devnchill

Copy link
Copy Markdown
Member Author

btw I had one silly question , once my pr is ready for review , should i squash them beforehand or let it have separate commits and you squash them 😅 ?

@fricklerhandwerk

Copy link
Copy Markdown
Collaborator

If you squash them I can just press the button, that makes it faster of course! But sometimes it's hard to know when one is really really done and then it degrades to a series of force pushes, at which point it becomes fiddly for me to figure out what even changed. So generally yes do it, but with a bit of care as to whether it's already time.

@devnchill

Copy link
Copy Markdown
Member Author

understood :)

@devnchill devnchill force-pushed the docs/data-ingestion-and-matching branch 2 times, most recently from 9194e4f to 0fbe877 Compare June 22, 2026 05:42
@devnchill

Copy link
Copy Markdown
Member Author

I rebased and squashed it

@fricklerhandwerk fricklerhandwerk changed the title docs: extrack data ingestion and matching into a separate doc docs: extract data ingestion and matching into a separate guide Jun 23, 2026
@fricklerhandwerk fricklerhandwerk force-pushed the docs/data-ingestion-and-matching branch from 0fbe877 to 68c9ef2 Compare June 23, 2026 21:30
@fricklerhandwerk fricklerhandwerk added this pull request to the merge queue Jun 23, 2026
Merged via the queue into NixOS:main with commit 9ac2f25 Jun 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants