feat: expose proposal false-positive ratio#1139
Open
DarshanCode2005 wants to merge 4 commits into
Open
Conversation
|
|
||
| Moreover, a [Postgres Exporter](https://github.com/prometheus-community/postgres_exporter) and a [SQL exporter](https://github.com/justwatchcom/sql_exporter) run in the host exposing Postgres and application specific metrics. A dashboard for these metrics is [here](https://grafana.nixos.org/d/beo2uotj65lvkb/nix-security-tracker?orgId=1&from=now-6h&to=now&timezone=browser&var-Instance=tracker.security.nixos.org:9237). | ||
|
|
||
| ### Application metrics |
Collaborator
There was a problem hiding this comment.
If you want to point people to the source of just the matching quality metrics, consider extracting just those into a separate file and point to that file. This is of course conditional on that these metrics are somewhat special. If they're not, it's enough to just point people to the general metrics file (and maybe rename it accordingly so it can be found more easily just by browsing the source).
fricklerhandwerk
approved these changes
Jun 24, 2026
fricklerhandwerk
left a comment
fricklerhandwerk
left a comment
Collaborator
There was a problem hiding this comment.
Looks alright, I need to fix the local Grafana setup to be able to test it though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #1002
Adds a false_positive_ratio SQL exporter metric: triaged proposal rejection rate (rejected / (accepted + rejected), with published counted as accepted). Users can see matching triage quality without running manual SQL.