fix: Require POST for social login instead of GET#1150
Draft
Erethon wants to merge 1 commit into
Draft
Conversation
The docs of allauth specify: > For security considerations, it is strongly recommended to require POST requests. This will add an extra step where the user needs to click on a "Continue" button before they can login.
Collaborator
|
IIRC the problem @florentc was that the API-based UI client doesn't eat the HTML response well. But we can use https://docs.allauth.org/en/latest/headless/index.html in that case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs of allauth specify:
This will add an extra step where the user needs to click on a "Continue" button before they can login. I'm opening this PR to discuss if this is a UX decision we made consciously or something that we happened to include. If it's the former, then I'll edit this PR to add a comment to the setting, because it caught me by surprise when looking at the code.