GET /notificaitons

[devnchill]

Related to #1024 (#1024 (comment))

notifications/ seems like a pretty standalone thing to tackle @devnchill, and I can implement the front side of things after. API only

• Adds REST API endpoint for GET notifications
• Tests for GET notifications

[DarshanCode2005]

tests are nice ❤️

suggestion: you should implement tests for GET /notifications/:id example:
1> retrieve own notification - 200
2> retrieve another user's notification - 404
3> retrieve non-existent id - 404

[DarshanCode2005]

for notification frontend will most likely require message for TextNotification you could confirm it with @florentc sir.

[DarshanCode2005]

@devnchill you could add @extend_schema for OPENAPI.

Also, test_token_auth.py probes auth on other endpoints, but notifications have no equivalent , a small test would document that API-key clients can use this endpoint.

[devnchill]

tests are nice ❤️

suggestion: you should implement tests for GET /notifications/:id example: 1> retrieve own notification - 200 2> retrieve another user's notification - 404 3> retrieve non-existent id - 404

thanks 😄 , yeah I was aware about missing test for that but thought it would it would be best practice to write tests for /notifications/:id in separate pr , this was meant just for GET /notification ... and /notification:id is kind of sideeffect of ReadOnly viewset 😅 ... @florentc @fricklerhandwerk any thoughts ....

[devnchill]

resolved merge conflicts and rebased 😅

[florentc]

Thanks for the PR and review. We'll indeed want the text content in the serialized text notifications. As for the suggestion notifications, we'll want the suggestion id so that the frontend or the user can query this suggestion later. I'm currently working on the suggestions API including the suggestion serializer so for now in this PR let's only return the suggestion_id. If needed in the future we can inline the suggestion in the response.